Skip to content

Commit 6f5cc6e

Browse files
committed
add verify-go-directive check from core CAPI
1 parent 32a907c commit 6f5cc6e

File tree

1 file changed

+8
-1
lines changed

1 file changed

+8
-1
lines changed

Makefile

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ export GO111MODULE=on
3434

3535
# Go version
3636
GOLANG_VERSION := 1.24.6
37+
GOLANG_DIRECTIVE_VERSION ?= 1.24.0
3738

3839
# Kubebuilder
3940
export KUBEBUILDER_ENVTEST_KUBERNETES_VERSION ?= 1.33.0
@@ -580,7 +581,7 @@ format-tiltfile: ## Format the Tiltfile.
580581
./hack/verify-starlark.sh fix
581582

582583
.PHONY: verify
583-
verify: verify-boilerplate verify-modules verify-gen verify-shellcheck verify-tiltfile verify-conversions
584+
verify: verify-boilerplate verify-modules verify-gen verify-shellcheck verify-tiltfile verify-conversions verify-go-directive
584585

585586
.PHONY: verify-boilerplate
586587
verify-boilerplate:
@@ -611,3 +612,9 @@ verify-gen: generate
611612
git diff HEAD; \
612613
exit 1; \
613614
fi
615+
616+
.PHONY: verify-go-directive
617+
verify-go-directive:
618+
# use the core Cluster API script directly to verify the go directive matches the desired one.
619+
# ref: https://github.com/kubernetes-sigs/cluster-api/blob/v1.10.7/hack/verify-go-directive.sh
620+
curl --retry $(CURL_RETRIES) -fsL https://raw.githubusercontent.com/kubernetes-sigs/cluster-api/refs/tags/v1.11.0/hack/verify-go-directive.sh | bash -s -- -g $(GOLANG_DIRECTIVE_VERSION)

0 commit comments

Comments
 (0)