Use reference for Internal LB address

bfournie · bfournie · commit ce0ffe890a29 · 2024-06-04T10:21:23.000-04:00
To be consistent with how all the other fields are set, including
APIServerAddress, the resource selfLink should be used, not the
actual IP address.
diff --git a/cloud/services/compute/loadbalancers/reconcile.go b/cloud/services/compute/loadbalancers/reconcile.go
@@ -234,7 +234,7 @@ func (s *Service) createInternalLoadBalancer(ctx context.Context, name string, l
 	if err != nil {
 		return err
 	}
-	s.scope.Network().APIInternalAddress = ptr.To[string](addr.Address)
+	s.scope.Network().APIInternalAddress = ptr.To[string](addr.SelfLink)
 	if lbType == infrav1.Internal {
 		// If only creating an internal Load Balancer, set the control plane endpoint
 		endpoint := s.scope.ControlPlaneEndpoint()

Original file line number	Diff line number	Diff line change
`@@ -234,7 +234,7 @@ func (s *Service) createInternalLoadBalancer(ctx context.Context, name string, l`
`234`	`234`	`if err != nil {`
`235`	`235`	`return err`
`236`	`236`	`}`
`237`		`- s.scope.Network().APIInternalAddress = ptr.To[string](addr.Address)`
	`237`	`+ s.scope.Network().APIInternalAddress = ptr.To[string](addr.SelfLink)`
`238`	`238`	`if lbType == infrav1.Internal {`
`239`	`239`	`// If only creating an internal Load Balancer, set the control plane endpoint`
`240`	`240`	`endpoint := s.scope.ControlPlaneEndpoint()`