Add unit tests for webhooks (#782)

Author: Amulyam24

api/v1beta1/ibmpowervscluster_webhook_test.go

@@ -0,0 +1,142 @@
+/*
+Copyright 2022 The Kubernetes Authors.
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package v1beta1
+
+import (
+	"testing"
+
+	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+	"k8s.io/utils/pointer"
+)
+
+func TestIBMPowerVSCluster_create(t *testing.T) {
+	tests := []struct {
+		name           string
+		powervsCluster *IBMPowerVSCluster
+		wantErr        bool
+	}{
+		{
+			name: "Should allow if either Network ID or name is set",
+			powervsCluster: &IBMPowerVSCluster{
+				Spec: IBMPowerVSClusterSpec{
+					ServiceInstanceID: "capi-si-id",
+					Network: IBMPowerVSResourceReference{
+						ID: pointer.String("capi-net-id"),
+					},
+				},
+			},
+			wantErr: false,
+		},
+		{
+			name: "Should error if both Network ID and name are set",
+			powervsCluster: &IBMPowerVSCluster{
+				Spec: IBMPowerVSClusterSpec{
+					ServiceInstanceID: "capi-si-id",
+					Network: IBMPowerVSResourceReference{
+						ID:   pointer.String("capi-net-id"),
+						Name: pointer.String("capi-net"),
+					},
+				},
+			},
+			wantErr: true,
+		},
+	}
+
+	for _, tc := range tests {
+		t.Run(tc.name, func(t *testing.T) {
+			cluster := tc.powervsCluster.DeepCopy()
+			cluster.ObjectMeta = metav1.ObjectMeta{
+				GenerateName: "capi-cluster-",
+				Namespace:    "default",
+			}
+
+			if err := testEnv.Create(ctx, cluster); (err != nil) != tc.wantErr {
+				t.Errorf("ValidateCreate() error = %v, wantErr %v", err, tc.wantErr)
+			}
+		})
+	}
+}
+
+func TestIBMPowerVSCluster_update(t *testing.T) {
+	tests := []struct {
+		name              string
+		oldPowervsCluster *IBMPowerVSCluster
+		newPowervsCluster *IBMPowerVSCluster
+		wantErr           bool
+	}{
+		{
+			name: "Should allow if either Network ID or name is set",
+			oldPowervsCluster: &IBMPowerVSCluster{
+				Spec: IBMPowerVSClusterSpec{
+					ServiceInstanceID: "capi-si-id",
+					Network: IBMPowerVSResourceReference{
+						ID: pointer.String("capi-net-id"),
+					},
+				},
+			},
+			newPowervsCluster: &IBMPowerVSCluster{
+				Spec: IBMPowerVSClusterSpec{
+					ServiceInstanceID: "capi-si-id",
+					Network: IBMPowerVSResourceReference{
+						ID: pointer.String("capi-net-id"),
+					},
+				},
+			},
+			wantErr: false,
+		},
+		{
+			name: "Should error if both Network ID and name are set",
+			oldPowervsCluster: &IBMPowerVSCluster{
+				Spec: IBMPowerVSClusterSpec{
+					ServiceInstanceID: "capi-si-id",
+					Network: IBMPowerVSResourceReference{
+						ID: pointer.String("capi-net-id"),
+					},
+				},
+			},
+			newPowervsCluster: &IBMPowerVSCluster{
+				Spec: IBMPowerVSClusterSpec{
+					ServiceInstanceID: "capi-si-id",
+					Network: IBMPowerVSResourceReference{
+						ID:   pointer.String("capi-net-id"),
+						Name: pointer.String("capi-net-name"),
+					},
+				},
+			},
+			wantErr: true,
+		},
+	}
+
+	for _, tc := range tests {
+		t.Run(tc.name, func(t *testing.T) {
+			cluster := tc.oldPowervsCluster.DeepCopy()
+			cluster.ObjectMeta = metav1.ObjectMeta{
+				GenerateName: "capi-cluster-",
+				Namespace:    "default",
+			}
+
+			if err := testEnv.Create(ctx, cluster); err != nil {
+				t.Errorf("failed to create cluster: %v", err)
+			}
+
+			cluster.Spec = tc.newPowervsCluster.Spec
+			if err := testEnv.Update(ctx, cluster); (err != nil) != tc.wantErr {
+				t.Errorf("ValidateUpdate() error = %v, wantErr %v", err, tc.wantErr)
+			}
+		})
+	}
+}