Commit 2298b0c
authored
Remove invalid kustomizeconfig from config/webhook (#2541)
This change has no effect on the output of this kustomization because
the removed configuration was redundant. However, it fixes a bug which
can be triggered when using this kustomization as a base for another
kustomization.
kustomizeconfig contained 3 directives:
* nameReference
* namespace
* varReference
varReference is redundant because vars are no longer used in this
kustomize: they are deprecated and usage was removed some time ago.
nameReference is redundant because the specified configuration is
already in kustomize's defaults. However, nameReference is the important
transformation here.
namespace is incorrect. It directs the namespace transformer to update
webhooks/clientConfig/service/namespace. However, this is not the
intended function of the namespace transformer: it should only set the
namespace directly on objects and allow references to be updated
automatically by nameReference. Configuring it to update a reference
directly leaves kustomize with inconsistent internal state. Depending on
execution order this can cause a subsequent transformation to fail to
update the reference when it makes further changes to the Service1 parent a4c2ae1 commit 2298b0c
2 files changed
+0
-28
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
5 | | - | |
6 | | - | |
This file was deleted.
0 commit comments