Enable additional linters (#856)

Signed-off-by: Prajyot-Parab <[email protected]>

Signed-off-by: Prajyot-Parab <[email protected]>
Co-authored-by: Prajyot-Parab <[email protected]>

Author: k8s-infra-cherrypick-robot

.golangci.yml

@@ -1,15 +1,21 @@
 linters:
   disable-all: true
   enable:
+  - asasalint
   - asciicheck
   - bodyclose
+  - containedctx
+  - decorder
   - depguard
   - dogsled
   - errcheck
+  - errchkjson
+  - execinquery
   - exportloopref
   - gci
   - goconst
   - gocritic
+  - gocyclo
   - godot
   - gofmt
   - goimports
@@ -24,8 +30,10 @@ linters:
   - nilerr
   - noctx
   - nolintlint
+  - nosprintfhostport
   - prealloc
   - predeclared
+  - reassign
   - revive
   - rowserrcheck
   - staticcheck
@@ -35,6 +43,7 @@ linters:
   - unconvert
   - unparam
   - unused
+  - usestdlibvars
   - whitespace
 
 linters-settings:

pkg/cloud/services/utils/accounts.go

@@ -29,7 +29,7 @@ import (
 func GetAccount(auth core.Authenticator) (string, error) {
 	// fake request to get a barer token from the request header
 	ctx := context.TODO()
-	req, err := http.NewRequestWithContext(ctx, "GET", "http://example.com", http.NoBody)
+	req, err := http.NewRequestWithContext(ctx, http.MethodGet, "http://example.com", http.NoBody)
 	if err != nil {
 		return "", err
 	}