Loosen linter rule for package names and fix an SA issue

Author: kishen-v

.golangci.yml

@@ -121,6 +121,10 @@ linters:
       - linters:
           - revive
         text: 'exported: exported method .*\.(Reconcile|SetupWithManager|SetupWebhookWithManager) should have comment or be unexported'
+        # To be fixed: This is done to unblock the bumping of golint.
+      - linters:
+          - revive
+        text: 'var-naming: avoid meaningless package names'
       - linters:
           - errcheck
         text: Error return value of .((os\.)?std(out|err)\..*|.*Close|.*Flush|os\.Remove(All)?|.*print(f|ln)?|os\.(Un)?(S|s)?etenv). is not checked

test/helpers/envtest.go

@@ -240,9 +240,10 @@ func (t *TestEnvironment) WaitForWebhooks() {
 	port := t.env.WebhookInstallOptions.LocalServingPort
 	klog.V(2).Infof("Waiting for webhook port %d to be open prior to running tests", port)
 	timeout := 1 * time.Second
+	d := net.Dialer{Timeout: timeout}
 	for {
 		time.Sleep(timeout)
-		conn, err := net.DialTimeout("tcp", net.JoinHostPort("127.0.0.1", strconv.Itoa(port)), timeout)
+		conn, err := d.DialContext(context.Background(), "tcp", net.JoinHostPort("127.0.0.1", strconv.Itoa(port)))
 		if err != nil {
 			klog.V(2).Infof("Webhook port is not ready, will retry in %v: %s", timeout, err)
 			continue