Skip to content

Commit 728a270

Browse files
committed
address review comments
1 parent 71e2e39 commit 728a270

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

api/v1beta2/conditions_consts.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -362,7 +362,7 @@ const (
362362

363363
// IBMPowerVSImage's Ready condition and corresponding reasons that will be used in v1Beta2 API version.
364364
const (
365-
// IBMPowerVSImageReadyCondition is true if the IBMPowerVSImage's deletionTimestamp is not set, IBMPowerVSImage's.
365+
// IBMPowerVSImageReadyCondition is true if the IBMPowerVSImage's deletionTimestamp is not set, IBMPowerVSImage's IBMPowerVSImageReadyV1Beta2Condition is true.
366366
IBMPowerVSImageReadyCondition = clusterv1beta1.ReadyV1Beta2Condition
367367

368368
// IBMPowerVSImageReadyV1Beta2Condition documents the Ready status of the image.

cloud/scope/powervs_image.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ func NewPowerVSImageScope(ctx context.Context, params PowerVSImageScopeParams) (
135135
// Fetch the service endpoint.
136136
if svcEndpoint := endpoints.FetchPVSEndpoint(endpoints.ConstructRegionFromZone(*res.RegionID), params.ServiceEndpoint); svcEndpoint != "" {
137137
options.IBMPIOptions.URL = svcEndpoint
138-
log.V(3).Info("overriding the default powervs service endpoint", "serviceEndpoint", svcEndpoint)
138+
log.V(3).Info("Overriding the default PowerVS service endpoint", "serviceEndpoint", svcEndpoint)
139139
}
140140

141141
c, err := powervs.NewService(options)
@@ -200,7 +200,7 @@ func (i *PowerVSImageScope) CreateImageCOSBucket(ctx context.Context) (*models.I
200200
record.Warnf(i.IBMPowerVSImage, "FailedCreateImageImportJob", "Failed image import job creation - %v", err)
201201
return nil, nil, err
202202
}
203-
log.Info("New import job request created", "jobID", *jobRef.ID)
203+
log.Info("New import job request created")
204204
record.Eventf(i.IBMPowerVSImage, "SuccessfulCreateImageImportJob", "Created image import job %q", *jobRef.ID)
205205
return nil, jobRef, nil
206206
}

0 commit comments

Comments
 (0)