Skip to content

Commit 72f387d

Browse files
authored
Update ccm dockerfile to remove building vpcctl binary (#671)
1 parent ffe528a commit 72f387d

File tree

2 files changed

+4
-16
lines changed

2 files changed

+4
-16
lines changed

hack/ccm/Dockerfile

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -18,15 +18,6 @@ ARG GOLANG_IMAGE=golang:1.17
1818
ARG TARGETPLATFORM=linux/amd64
1919
ARG ARCH=amd64
2020

21-
# Build vpcctl binary
22-
FROM ${GOLANG_IMAGE} as vpc-builder
23-
ARG ARCH
24-
ARG VPC_CONTROLLER_COMMIT
25-
WORKDIR /build
26-
RUN git clone https://github.com/openshift/cloud-provider-vpc-controller
27-
RUN cd cloud-provider-vpc-controller/cmd && git checkout $VPC_CONTROLLER_COMMIT && CGO_ENABLED=0 GOARCH=$ARCH go build \
28-
-ldflags "-s -w" -o /build/vpcctl .
29-
3021
# Build IBM cloud controller manager binary
3122
FROM ${GOLANG_IMAGE} AS ccm-builder
3223
ARG ARCH
@@ -39,6 +30,5 @@ RUN cd cloud-provider-powervs && git checkout $POWERVS_CLOUD_CONTROLLER_COMMIT &
3930
# Assemble the final image
4031
FROM --platform=$TARGETPLATFORM quay.io/centos/centos:stream8 AS centos-base
4132
LABEL description="IBM PowerVS Cloud Controller Manager"
42-
COPY --from=vpc-builder /build/vpcctl /bin/vpcctl
4333
COPY --from=ccm-builder /build/ibm-cloud-controller-manager /bin/ibm-cloud-controller-manager
4434
ENTRYPOINT [ "/bin/ibm-cloud-controller-manager" ]

hack/ccm/Makefile

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,18 +15,16 @@
1515
REGISTRY=gcr.io/k8s-staging-capi-ibmcloud
1616
IMG=powervs-cloud-controller-manager
1717

18-
# VPC_CONTROLLER_COMMIT can be fetched from here https://github.com/openshift/cloud-provider-vpc-controller/commits/master
19-
VPC_CONTROLLER_COMMIT?=9b99b4e
2018
# POWERVS_CLOUD_CONTROLLER_COMMIT can be fetched from here https://github.com/openshift/cloud-provider-powervs/commits/main
21-
POWERVS_CLOUD_CONTROLLER_COMMIT?=a6bfa07
22-
TAG?=$(VPC_CONTROLLER_COMMIT)_$(POWERVS_CLOUD_CONTROLLER_COMMIT)
19+
POWERVS_CLOUD_CONTROLLER_COMMIT?=0b18bec
20+
TAG?=$(POWERVS_CLOUD_CONTROLLER_COMMIT)
2321

2422
build-image-and-push-linux-amd64: init-buildx
2523
{ \
2624
set -e ; \
2725
docker buildx build \
2826
--build-arg TARGETPLATFORM=linux/amd64 --build-arg ARCH=amd64 \
29-
--build-arg VPC_CONTROLLER_COMMIT=$(VPC_CONTROLLER_COMMIT) --build-arg POWERVS_CLOUD_CONTROLLER_COMMIT=$(POWERVS_CLOUD_CONTROLLER_COMMIT)\
27+
--build-arg POWERVS_CLOUD_CONTROLLER_COMMIT=$(POWERVS_CLOUD_CONTROLLER_COMMIT)\
3028
-t $(REGISTRY)/$(IMG):$(TAG)_linux_amd64 . --push --target centos-base; \
3129
}
3230

@@ -35,7 +33,7 @@ build-image-and-push-linux-ppc64le: init-buildx
3533
set -e ; \
3634
docker buildx build \
3735
--build-arg TARGETPLATFORM=linux/ppc64le --build-arg ARCH=ppc64le\
38-
--build-arg VPC_CONTROLLER_COMMIT=$(VPC_CONTROLLER_COMMIT) --build-arg POWERVS_CLOUD_CONTROLLER_COMMIT=$(POWERVS_CLOUD_CONTROLLER_COMMIT)\
36+
--build-arg POWERVS_CLOUD_CONTROLLER_COMMIT=$(POWERVS_CLOUD_CONTROLLER_COMMIT)\
3937
-t $(REGISTRY)/$(IMG):$(TAG)_linux_ppc64le . --push --target centos-base; \
4038
}
4139

0 commit comments

Comments
 (0)