Skip to content

Commit 766ba45

Browse files
Minor spec comments update (#1042)
Signed-off-by: Prajyot-Parab <[email protected]> Signed-off-by: Prajyot-Parab <[email protected]>
1 parent bad4205 commit 766ba45

File tree

3 files changed

+19
-9
lines changed

3 files changed

+19
-9
lines changed

api/v1beta2/ibmpowervsmachine_types.go

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,8 @@ type IBMPowerVSMachineSpec struct {
5454
// SSHKey is the name of the SSH key pair provided to the vsi for authenticating users.
5555
SSHKey string `json:"sshKey,omitempty"`
5656

57-
// Image is the reference to the Image from which to create the machine instance.
57+
// Image the reference to the image which is used to create the instance.
58+
// supported image identifier in IBMPowerVSResourceReference are Name and ID and that can be obtained from IBM Cloud UI or IBM Cloud cli.
5859
// +optional
5960
Image *IBMPowerVSResourceReference `json:"image,omitempty"`
6061

@@ -114,15 +115,16 @@ type IBMPowerVSMachineSpec struct {
114115
MemoryGiB int32 `json:"memoryGiB,omitempty"`
115116

116117
// Network is the reference to the Network to use for this instance.
118+
// supported network identifier in IBMPowerVSResourceReference are Name, ID and RegEx and that can be obtained from IBM Cloud UI or IBM Cloud cli.
117119
Network IBMPowerVSResourceReference `json:"network"`
118120

119121
// ProviderID is the unique identifier as specified by the cloud provider.
120122
// +optional
121123
ProviderID *string `json:"providerID,omitempty"`
122124
}
123125

124-
// IBMPowerVSResourceReference is a reference to a specific PowerVS resource by ID or Name
125-
// Only one of ID or Name may be specified. Specifying more than one will result in
126+
// IBMPowerVSResourceReference is a reference to a specific PowerVS resource by ID, Name or RegEx
127+
// Only one of ID, Name or RegEx may be specified. Specifying more than one will result in
126128
// a validation error.
127129
type IBMPowerVSResourceReference struct {
128130
// ID of resource

config/crd/bases/infrastructure.cluster.x-k8s.io_ibmpowervsmachines.yaml

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -329,8 +329,10 @@ spec:
329329
description: IBMPowerVSMachineSpec defines the desired state of IBMPowerVSMachine.
330330
properties:
331331
image:
332-
description: Image is the reference to the Image from which to create
333-
the machine instance.
332+
description: Image the reference to the image which is used to create
333+
the instance. supported image identifier in IBMPowerVSResourceReference
334+
are Name and ID and that can be obtained from IBM Cloud UI or IBM
335+
Cloud cli.
334336
properties:
335337
id:
336338
description: ID of resource
@@ -372,7 +374,9 @@ spec:
372374
type: integer
373375
network:
374376
description: Network is the reference to the Network to use for this
375-
instance.
377+
instance. supported network identifier in IBMPowerVSResourceReference
378+
are Name, ID and RegEx and that can be obtained from IBM Cloud UI
379+
or IBM Cloud cli.
376380
properties:
377381
id:
378382
description: ID of resource

config/crd/bases/infrastructure.cluster.x-k8s.io_ibmpowervsmachinetemplates.yaml

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -183,8 +183,10 @@ spec:
183183
IBMPowerVSMachine.
184184
properties:
185185
image:
186-
description: Image is the reference to the Image from which
187-
to create the machine instance.
186+
description: Image the reference to the image which is used
187+
to create the instance. supported image identifier in IBMPowerVSResourceReference
188+
are Name and ID and that can be obtained from IBM Cloud
189+
UI or IBM Cloud cli.
188190
properties:
189191
id:
190192
description: ID of resource
@@ -227,7 +229,9 @@ spec:
227229
type: integer
228230
network:
229231
description: Network is the reference to the Network to use
230-
for this instance.
232+
for this instance. supported network identifier in IBMPowerVSResourceReference
233+
are Name, ID and RegEx and that can be obtained from IBM
234+
Cloud UI or IBM Cloud cli.
231235
properties:
232236
id:
233237
description: ID of resource

0 commit comments

Comments
 (0)