Skip to content

Commit 817673e

Browse files
authored
Improve UT coverage for controllers pkg (#743)
1 parent c4c46a9 commit 817673e

File tree

6 files changed

+1045
-6
lines changed

6 files changed

+1045
-6
lines changed

cloud/scope/powervs_image.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ type PowerVSImageScopeParams struct {
5555
// PowerVSImageScope defines a scope defined around a Power VS Cluster.
5656
type PowerVSImageScope struct {
5757
logr.Logger
58-
client client.Client
58+
Client client.Client
5959
patchHelper *patch.Helper
6060

6161
IBMPowerVSClient powervs.PowerVS
@@ -72,7 +72,7 @@ func NewPowerVSImageScope(params PowerVSImageScopeParams) (scope *PowerVSImageSc
7272
err = errors.New("failed to generate new scope from nil Client")
7373
return
7474
}
75-
scope.client = params.Client
75+
scope.Client = params.Client
7676

7777
if params.IBMPowerVSImage == nil {
7878
err = errors.New("failed to generate new scope from nil IBMPowerVSImage")

cloud/scope/powervs_image_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ func setupPowerVSImageScope(imageName string, mockpowervs *mock.MockPowerVS) *Po
6060

6161
client := fake.NewClientBuilder().WithScheme(scheme.Scheme).WithObjects(initObjects...).Build()
6262
return &PowerVSImageScope{
63-
client: client,
63+
Client: client,
6464
Logger: klogr.New(),
6565
IBMPowerVSClient: mockpowervs,
6666
IBMPowerVSImage: powervsImage,

controllers/ibmpowervscluster_controller_test.go

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,17 +21,18 @@ import (
2121
"testing"
2222
"time"
2323

24-
. "github.com/onsi/gomega"
2524
corev1 "k8s.io/api/core/v1"
2625
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
2726
"k8s.io/klog/v2/klogr"
27+
capiv1beta1 "sigs.k8s.io/cluster-api/api/v1beta1"
28+
"sigs.k8s.io/cluster-api/util"
2829
ctrl "sigs.k8s.io/controller-runtime"
2930
"sigs.k8s.io/controller-runtime/pkg/client"
3031

3132
infrav1beta1 "sigs.k8s.io/cluster-api-provider-ibmcloud/api/v1beta1"
3233
"sigs.k8s.io/cluster-api-provider-ibmcloud/cloud/scope"
33-
capiv1beta1 "sigs.k8s.io/cluster-api/api/v1beta1"
34-
"sigs.k8s.io/cluster-api/util"
34+
35+
. "github.com/onsi/gomega"
3536
)
3637

3738
func TestIBMPowerVSClusterReconciler_Reconcile(t *testing.T) {

0 commit comments

Comments
 (0)