Skip to content

Commit a215445

Browse files
committed
address review comments
1 parent ea297d2 commit a215445

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

docs/proposal/controller-and-user-tags.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ PowerVS cluster reconciler sets [controllerCreated](https://github.com/kubernete
77

88
Though its working as expected and fulfills the purpose, we see some drawbacks.
99
1. The field is initially set to true during the first reconciliation cycle when the resource is being created. In subsequent reconciliation loops, the field is not updated because the resource already exists in the cloud(created during first reconciliation). This behavior introduces non-idempotency in the controller logic. As a result, if the initial reconciliation event is missed, the controller exhibits inconsistent behavior. Its against Kubernetes principle of reconciliation of having level trigger rather than edge triggered.
10-
2. The Status subresource in a resource object is expected to be created from spec, considering the scenario of backup and recover. If we move the spec to fresh management cluster which is setting the status, the controller created will be set as false as the resource already exists in cloud but it was created during its previous reconciliation.
10+
2. The Status field in resource object is expected to be created from spec, considering the scenario of backup and recover. If we move the spec to fresh management cluster which is setting the status, the controller created will be set as false as the resource already exists in cloud but it was created during its previous reconciliation.
1111

1212
## Goal
1313
1. Tag newly created PowerVS Cluster's cloud resources and delete the resources based on tag.

0 commit comments

Comments
 (0)