Skip to content

Commit acda62d

Browse files
Karthik-K-NPacho20
Karthik-K-N
authored and
Pacho20
committed
Bump vpc-go-sdk and replace all with icmp_tcp_udp
The latest vpc-go-sdk release introduced a breaking change to SecurityGroupRuleProtocol: the value 'all' was removed and replaced by 'icmp_tcp_udp'. This commit updates the security group rule creation and validation to use 'icmp_tcp_udp' instead of 'all'.
1 parent 4800a3b commit acda62d

11 files changed

+94
-94
lines changed

‎api/powervs/v1beta2/types.go‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -285,8 +285,8 @@ var (
285285
)
286286

287287
const (
288-
// VPCSecurityGroupRuleProtocolAllType is a string representation of the 'SecurityGroupRuleSecurityGroupRuleProtocolAll' type.
289-
VPCSecurityGroupRuleProtocolAllType = "*vpcv1.SecurityGroupRuleSecurityGroupRuleProtocolAll"
288+
// VPCSecurityGroupRuleProtocolIcmptcpudpType is a string representation of the 'SecurityGroupRuleProtocolIcmptcpudp' type.
289+
VPCSecurityGroupRuleProtocolIcmptcpudpType = "*vpcv1.SecurityGroupRuleProtocolIcmptcpudp"
290290

291291
// VPCSecurityGroupRuleProtocolIcmpType is a string representation of the 'SecurityGroupRuleSecurityGroupRuleProtocolIcmp' type.
292292
VPCSecurityGroupRuleProtocolIcmpType = "*vpcv1.SecurityGroupRuleSecurityGroupRuleProtocolIcmp"
@@ -318,12 +318,12 @@ const (
318318
)
319319

320320
// VPCSecurityGroupRuleProtocol represents the protocols for a Security Group Rule.
321-
// +kubebuilder:validation:Enum=all;icmp;tcp;udp
321+
// +kubebuilder:validation:Enum=icmp_tcp_udp;icmp;tcp;udp
322322
type VPCSecurityGroupRuleProtocol string
323323

324324
const (
325-
// VPCSecurityGroupRuleProtocolAll defines the Rule is for all network protocols.
326-
VPCSecurityGroupRuleProtocolAll VPCSecurityGroupRuleProtocol = vpcv1.NetworkACLRuleProtocolAllConst
325+
// VPCSecurityGroupRuleProtocolIcmpTCPUDP defines the Rule is for ICMP, TCP and UDP protocols.
326+
VPCSecurityGroupRuleProtocolIcmpTCPUDP VPCSecurityGroupRuleProtocol = vpcv1.NetworkACLRuleProtocolIcmpTCPUDPConst
327327
// VPCSecurityGroupRuleProtocolIcmp defiens the Rule is for ICMP network protocol.
328328
VPCSecurityGroupRuleProtocolIcmp VPCSecurityGroupRuleProtocol = vpcv1.NetworkACLRuleProtocolIcmpConst
329329
// VPCSecurityGroupRuleProtocolTCP defines the Rule is for TCP network protocol.
@@ -446,8 +446,8 @@ type VPCSecurityGroupRuleRemote struct {
446446

447447
// VPCSecurityGroupRulePrototype defines a VPC Security Group Rule's traffic specifics for a series of remotes (destinations or sources).
448448
// +kubebuilder:validation:XValidation:rule="self.protocol != 'icmp' ? (!has(self.icmpCode) && !has(self.icmpType)) : true",message="icmpCode and icmpType are only supported for VPCSecurityGroupRuleProtocolIcmp protocol"
449-
// +kubebuilder:validation:XValidation:rule="self.protocol == 'all' ? !has(self.portRange) : true",message="portRange is not valid for VPCSecurityGroupRuleProtocolAll protocol"
450449
// +kubebuilder:validation:XValidation:rule="self.protocol == 'icmp' ? !has(self.portRange) : true",message="portRange is not valid for VPCSecurityGroupRuleProtocolIcmp protocol"
450+
// +kubebuilder:validation:XValidation:rule="self.protocol == 'icmp_tcp_udp' ? !has(self.portRange) : true",message="portRange is not valid for VPCSecurityGroupRuleProtocolIcmpTCPUDP protocol"
451451
type VPCSecurityGroupRulePrototype struct {
452452
// icmpCode is the ICMP code for the Rule.
453453
// Only used when Protocol is VPCSecurityGroupRuleProtocolIcmp.

‎api/vpc/v1beta2/types.go‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -164,8 +164,8 @@ var (
164164
)
165165

166166
const (
167-
// VPCSecurityGroupRuleProtocolAllType is a string representation of the 'SecurityGroupRuleSecurityGroupRuleProtocolAll' type.
168-
VPCSecurityGroupRuleProtocolAllType = "*vpcv1.SecurityGroupRuleSecurityGroupRuleProtocolAll"
167+
// VPCSecurityGroupRuleProtocolIcmptcpudpType is a string representation of the 'SecurityGroupRuleProtocolIcmptcpudp' type.
168+
VPCSecurityGroupRuleProtocolIcmptcpudpType = "*vpcv1.SecurityGroupRuleProtocolIcmptcpudp"
169169

170170
// VPCSecurityGroupRuleProtocolIcmpType is a string representation of the 'SecurityGroupRuleSecurityGroupRuleProtocolIcmp' type.
171171
VPCSecurityGroupRuleProtocolIcmpType = "*vpcv1.SecurityGroupRuleSecurityGroupRuleProtocolIcmp"
@@ -197,12 +197,12 @@ const (
197197
)
198198

199199
// VPCSecurityGroupRuleProtocol represents the protocols for a Security Group Rule.
200-
// +kubebuilder:validation:Enum=all;icmp;tcp;udp
200+
// +kubebuilder:validation:Enum=icmp_tcp_udp;icmp;tcp;udp
201201
type VPCSecurityGroupRuleProtocol string
202202

203203
const (
204-
// VPCSecurityGroupRuleProtocolAll defines the Rule is for all network protocols.
205-
VPCSecurityGroupRuleProtocolAll VPCSecurityGroupRuleProtocol = vpcv1.NetworkACLRuleProtocolAllConst
204+
// VPCSecurityGroupRuleProtocolIcmpTCPUDP defines the Rule is for ICMP, TCP and UDP protocols.
205+
VPCSecurityGroupRuleProtocolIcmpTCPUDP VPCSecurityGroupRuleProtocol = vpcv1.NetworkACLRuleProtocolIcmpTCPUDPConst
206206
// VPCSecurityGroupRuleProtocolIcmp defiens the Rule is for ICMP network protocol.
207207
VPCSecurityGroupRuleProtocolIcmp VPCSecurityGroupRuleProtocol = vpcv1.NetworkACLRuleProtocolIcmpConst
208208
// VPCSecurityGroupRuleProtocolTCP defines the Rule is for TCP network protocol.
@@ -398,8 +398,8 @@ type VPCSecurityGroupRuleRemote struct {
398398

399399
// VPCSecurityGroupRulePrototype defines a VPC Security Group Rule's traffic specifics for a series of remotes (destinations or sources).
400400
// +kubebuilder:validation:XValidation:rule="self.protocol != 'icmp' ? (!has(self.icmpCode) && !has(self.icmpType)) : true",message="icmpCode and icmpType are only supported for VPCSecurityGroupRuleProtocolIcmp protocol"
401-
// +kubebuilder:validation:XValidation:rule="self.protocol == 'all' ? !has(self.portRange) : true",message="portRange is not valid for VPCSecurityGroupRuleProtocolAll protocol"
402401
// +kubebuilder:validation:XValidation:rule="self.protocol == 'icmp' ? !has(self.portRange) : true",message="portRange is not valid for VPCSecurityGroupRuleProtocolIcmp protocol"
402+
// +kubebuilder:validation:XValidation:rule="self.protocol == 'icmp_tcp_udp' ? !has(self.portRange) : true",message="portRange is not valid for VPCSecurityGroupRuleProtocolIcmpTCPUDP protocol"
403403
type VPCSecurityGroupRulePrototype struct {
404404
// icmpCode is the ICMP code for the Rule.
405405
// Only used when Protocol is VPCSecurityGroupRuleProtocolIcmp.

‎cloud/scope/powervs/powervs_cluster.go‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1462,13 +1462,13 @@ func (s *ClusterScope) createVPCSecurityGroupRule(ctx context.Context, securityG
14621462
}
14631463

14641464
switch reflect.TypeOf(ruleIntf).String() {
1465-
case "*vpcv1.SecurityGroupRuleSecurityGroupRuleProtocolAll":
1466-
rule := ruleIntf.(*vpcv1.SecurityGroupRuleSecurityGroupRuleProtocolAll)
1465+
case infrav1.VPCSecurityGroupRuleProtocolIcmptcpudpType:
1466+
rule := ruleIntf.(*vpcv1.SecurityGroupRuleProtocolIcmptcpudp)
14671467
ruleID = rule.ID
1468-
case "*vpcv1.SecurityGroupRuleSecurityGroupRuleProtocolTcpudp":
1468+
case infrav1.VPCSecurityGroupRuleProtocolTcpudpType:
14691469
rule := ruleIntf.(*vpcv1.SecurityGroupRuleSecurityGroupRuleProtocolTcpudp)
14701470
ruleID = rule.ID
1471-
case "*vpcv1.SecurityGroupRuleSecurityGroupRuleProtocolIcmp":
1471+
case infrav1.VPCSecurityGroupRuleProtocolIcmpType:
14721472
rule := ruleIntf.(*vpcv1.SecurityGroupRuleSecurityGroupRuleProtocolIcmp)
14731473
ruleID = rule.ID
14741474
}
@@ -1609,8 +1609,8 @@ func (s *ClusterScope) validateSecurityGroupRule(originalSecurityGroupRules []vp
16091609

16101610
for _, ogRuleIntf := range originalSecurityGroupRules {
16111611
switch reflect.TypeOf(ogRuleIntf).String() {
1612-
case "*vpcv1.SecurityGroupRuleSecurityGroupRuleProtocolAll":
1613-
ogRule := ogRuleIntf.(*vpcv1.SecurityGroupRuleSecurityGroupRuleProtocolAll)
1612+
case infrav1.VPCSecurityGroupRuleProtocolIcmptcpudpType:
1613+
ogRule := ogRuleIntf.(*vpcv1.SecurityGroupRuleProtocolIcmptcpudp)
16141614
ruleID = ogRule.ID
16151615

16161616
if *ogRule.Direction == string(direction) && *ogRule.Protocol == protocol {
@@ -1621,7 +1621,7 @@ func (s *ClusterScope) validateSecurityGroupRule(originalSecurityGroupRules []vp
16211621
return nil, false, err
16221622
}
16231623
}
1624-
case "*vpcv1.SecurityGroupRuleSecurityGroupRuleProtocolTcpudp":
1624+
case infrav1.VPCSecurityGroupRuleProtocolTcpudpType:
16251625
portMin := rule.PortRange.MinimumPort
16261626
portMax := rule.PortRange.MaximumPort
16271627
ogRule := ogRuleIntf.(*vpcv1.SecurityGroupRuleSecurityGroupRuleProtocolTcpudp)
@@ -1635,7 +1635,7 @@ func (s *ClusterScope) validateSecurityGroupRule(originalSecurityGroupRules []vp
16351635
return nil, false, err
16361636
}
16371637
}
1638-
case "*vpcv1.SecurityGroupRuleSecurityGroupRuleProtocolIcmp":
1638+
case infrav1.VPCSecurityGroupRuleProtocolIcmpType:
16391639
icmpCode := rule.ICMPCode
16401640
icmpType := rule.ICMPType
16411641
ogRule := ogRuleIntf.(*vpcv1.SecurityGroupRuleSecurityGroupRuleProtocolIcmp)

‎cloud/scope/powervs/powervs_cluster_test.go‎

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -7549,7 +7549,7 @@ func TestValidateVPCSecurityGroup(t *testing.T) {
75497549
Protocol: infrav1.VPCSecurityGroupRuleProtocolTCP,
75507550
},
75517551
}
7552-
vpcSecurityGroupRule := vpcv1.SecurityGroupRuleSecurityGroupRuleProtocolAll{
7552+
vpcSecurityGroupRule := vpcv1.SecurityGroupRuleProtocolIcmptcpudp{
75537553
Direction: ptr.To("outbound"),
75547554
Protocol: ptr.To("tcp"),
75557555
Remote: &vpcv1.SecurityGroupRuleRemote{
@@ -7597,7 +7597,7 @@ func TestValidateVPCSecurityGroup(t *testing.T) {
75977597
Protocol: infrav1.VPCSecurityGroupRuleProtocolTCP,
75987598
},
75997599
}
7600-
vpcSecurityGroupRule := vpcv1.SecurityGroupRuleSecurityGroupRuleProtocolAll{
7600+
vpcSecurityGroupRule := vpcv1.SecurityGroupRuleProtocolIcmptcpudp{
76017601
Direction: ptr.To("outbound"),
76027602
Protocol: ptr.To("tcp"),
76037603
Remote: &vpcv1.SecurityGroupRuleRemote{
@@ -7864,7 +7864,7 @@ func TestValidateVPCSecurityGroup(t *testing.T) {
78647864
}
78657865

78667866
securityGroupDetails := &vpcv1.SecurityGroup{Name: ptr.To("securityGroupName"), ID: ptr.To("securityGroupID"), VPC: &vpcv1.VPCReference{ID: ptr.To("VPCID")}}
7867-
mockVPC.EXPECT().CreateSecurityGroupRule(gomock.Any()).Return(&vpcv1.SecurityGroupRuleSecurityGroupRuleProtocolAll{Protocol: ptr.To("tcp"), ID: ptr.To("ruleID")}, nil, nil)
7867+
mockVPC.EXPECT().CreateSecurityGroupRule(gomock.Any()).Return(&vpcv1.SecurityGroupRuleProtocolIcmptcpudp{Protocol: ptr.To("tcp"), ID: ptr.To("ruleID")}, nil, nil)
78687868
mockVPC.EXPECT().GetSecurityGroupByName(gomock.Any()).Return(securityGroupDetails, nil)
78697869
sg, ruleIDs, err := clusterScope.validateVPCSecurityGroup(ctx, vpcSecurityGroup)
78707870
g.Expect(ruleIDs).To(BeNil())
@@ -7885,7 +7885,7 @@ func TestValidateVPCSecurityGroup(t *testing.T) {
78857885
Protocol: infrav1.VPCSecurityGroupRuleProtocolTCP,
78867886
},
78877887
}
7888-
vpcSecurityGroupRule := vpcv1.SecurityGroupRuleSecurityGroupRuleProtocolAll{
7888+
vpcSecurityGroupRule := vpcv1.SecurityGroupRuleProtocolIcmptcpudp{
78897889
Direction: ptr.To("outbound"),
78907890
Protocol: ptr.To("tcp"),
78917891
Remote: &vpcv1.SecurityGroupRuleRemote{
@@ -8097,7 +8097,7 @@ func TestValidateVPCSecurityGroupRule(t *testing.T) {
80978097
g.Expect(match).To(BeFalse())
80988098
g.Expect(err).ToNot(BeNil())
80998099
})
8100-
t.Run("When it matches SecurityGroupRule of protocolType SecurityGroupRuleSecurityGroupRuleProtocolAll", func(t *testing.T) {
8100+
t.Run("When it matches SecurityGroupRule of protocolType SecurityGroupRuleProtocolIcmptcpudp", func(t *testing.T) {
81018101
g := NewWithT(t)
81028102
setup(t)
81038103
t.Cleanup(teardown)
@@ -8111,7 +8111,7 @@ func TestValidateVPCSecurityGroupRule(t *testing.T) {
81118111
Protocol: infrav1.VPCSecurityGroupRuleProtocolTCP,
81128112
},
81138113
}
8114-
vpcSecurityGroupRule := vpcv1.SecurityGroupRuleSecurityGroupRuleProtocolAll{
8114+
vpcSecurityGroupRule := vpcv1.SecurityGroupRuleProtocolIcmptcpudp{
81158115
Direction: ptr.To("outbound"),
81168116
Protocol: ptr.To("tcp"),
81178117
Remote: &vpcv1.SecurityGroupRuleRemote{
@@ -8145,7 +8145,7 @@ func TestValidateVPCSecurityGroupRule(t *testing.T) {
81458145
g.Expect(match).To(BeTrue())
81468146
g.Expect(err).To(BeNil())
81478147
})
8148-
t.Run("When it doesn't match SecurityGroupRule of protocolType SecurityGroupRuleSecurityGroupRuleProtocolAll", func(t *testing.T) {
8148+
t.Run("When it doesn't match SecurityGroupRule of protocolType SecurityGroupRuleProtocolIcmptcpudp", func(t *testing.T) {
81498149
g := NewWithT(t)
81508150
setup(t)
81518151
t.Cleanup(teardown)
@@ -8160,7 +8160,7 @@ func TestValidateVPCSecurityGroupRule(t *testing.T) {
81608160
Protocol: infrav1.VPCSecurityGroupRuleProtocolTCP,
81618161
},
81628162
}
8163-
vpcSecurityGroupRule := vpcv1.SecurityGroupRuleSecurityGroupRuleProtocolAll{
8163+
vpcSecurityGroupRule := vpcv1.SecurityGroupRuleProtocolIcmptcpudp{
81648164
Direction: ptr.To("outbound"),
81658165
Protocol: ptr.To("tcp"),
81668166
Remote: &vpcv1.SecurityGroupRuleRemote{
@@ -8194,7 +8194,7 @@ func TestValidateVPCSecurityGroupRule(t *testing.T) {
81948194
g.Expect(match).To(BeFalse())
81958195
g.Expect(err).To(BeNil())
81968196
})
8197-
t.Run("When SecurityGroupRule of protocolType SecurityGroupRuleSecurityGroupRuleProtocolAll returns error", func(t *testing.T) {
8197+
t.Run("When SecurityGroupRule of protocolType SecurityGroupRuleProtocolIcmptcpudp returns error", func(t *testing.T) {
81988198
g := NewWithT(t)
81998199
setup(t)
82008200
t.Cleanup(teardown)
@@ -8209,7 +8209,7 @@ func TestValidateVPCSecurityGroupRule(t *testing.T) {
82098209
Protocol: infrav1.VPCSecurityGroupRuleProtocolTCP,
82108210
},
82118211
}
8212-
vpcSecurityGroupRule := vpcv1.SecurityGroupRuleSecurityGroupRuleProtocolAll{
8212+
vpcSecurityGroupRule := vpcv1.SecurityGroupRuleProtocolIcmptcpudp{
82138213
Direction: ptr.To("outbound"),
82148214
Protocol: ptr.To("tcp"),
82158215
Remote: &vpcv1.SecurityGroupRuleRemote{
@@ -8431,7 +8431,7 @@ func TestValidateVPCSecurityGroupRules(t *testing.T) {
84318431
Protocol: infrav1.VPCSecurityGroupRuleProtocolTCP,
84328432
},
84338433
}
8434-
vpcSecurityGroupRule := vpcv1.SecurityGroupRuleSecurityGroupRuleProtocolAll{
8434+
vpcSecurityGroupRule := vpcv1.SecurityGroupRuleProtocolIcmptcpudp{
84358435
Direction: ptr.To("inbound"),
84368436
Protocol: ptr.To("tcp"),
84378437
Remote: &vpcv1.SecurityGroupRuleRemote{
@@ -8477,7 +8477,7 @@ func TestValidateVPCSecurityGroupRules(t *testing.T) {
84778477
Protocol: infrav1.VPCSecurityGroupRuleProtocolTCP,
84788478
},
84798479
}
8480-
vpcSecurityGroupRule := vpcv1.SecurityGroupRuleSecurityGroupRuleProtocolAll{
8480+
vpcSecurityGroupRule := vpcv1.SecurityGroupRuleProtocolIcmptcpudp{
84818481
Direction: ptr.To("inbound"),
84828482
Protocol: ptr.To("tcp"),
84838483
Remote: &vpcv1.SecurityGroupRuleRemote{
@@ -8525,7 +8525,7 @@ func TestValidateVPCSecurityGroupRules(t *testing.T) {
85258525
Protocol: infrav1.VPCSecurityGroupRuleProtocolTCP,
85268526
},
85278527
}
8528-
vpcSecurityGroupRule := vpcv1.SecurityGroupRuleSecurityGroupRuleProtocolAll{
8528+
vpcSecurityGroupRule := vpcv1.SecurityGroupRuleProtocolIcmptcpudp{
85298529
Direction: ptr.To("inbound"),
85308530
Protocol: ptr.To("tcp"),
85318531
Remote: &vpcv1.SecurityGroupRuleRemote{
@@ -8572,7 +8572,7 @@ func TestValidateVPCSecurityGroupRules(t *testing.T) {
85728572
Protocol: infrav1.VPCSecurityGroupRuleProtocolTCP,
85738573
},
85748574
}
8575-
vpcSecurityGroupRule := vpcv1.SecurityGroupRuleSecurityGroupRuleProtocolAll{
8575+
vpcSecurityGroupRule := vpcv1.SecurityGroupRuleProtocolIcmptcpudp{
85768576
Direction: ptr.To("outbound"),
85778577
Protocol: ptr.To("tcp"),
85788578
Remote: &vpcv1.SecurityGroupRuleRemote{
@@ -8618,7 +8618,7 @@ func TestValidateVPCSecurityGroupRules(t *testing.T) {
86188618
Protocol: infrav1.VPCSecurityGroupRuleProtocolTCP,
86198619
},
86208620
}
8621-
vpcSecurityGroupRule := vpcv1.SecurityGroupRuleSecurityGroupRuleProtocolAll{
8621+
vpcSecurityGroupRule := vpcv1.SecurityGroupRuleProtocolIcmptcpudp{
86228622
Direction: ptr.To("outbound"),
86238623
Protocol: ptr.To("tcp"),
86248624
Remote: &vpcv1.SecurityGroupRuleRemote{
@@ -9093,7 +9093,7 @@ func TestCreateVPCSecurityGroupRule(t *testing.T) {
90939093
},
90949094
}
90959095

9096-
mockVPC.EXPECT().CreateSecurityGroupRule(gomock.Any()).Return(&vpcv1.SecurityGroupRuleSecurityGroupRuleProtocolAll{Direction: ptr.To("outbound"), ID: ptr.To("ruleID")}, nil, nil)
9096+
mockVPC.EXPECT().CreateSecurityGroupRule(gomock.Any()).Return(&vpcv1.SecurityGroupRuleProtocolIcmptcpudp{Direction: ptr.To("outbound"), ID: ptr.To("ruleID")}, nil, nil)
90979097
ruleID, err := clusterScope.createVPCSecurityGroupRule(ctx, &securityGroupID, ptr.To("outbound"), &protocol, &portMin, &portMax, remote)
90989098
g.Expect(ruleID).To(BeEquivalentTo(ptr.To("ruleID")))
90999099
g.Expect(err).To(BeNil())
@@ -9207,7 +9207,7 @@ func TestCreateVPCSecurityGroupRule(t *testing.T) {
92079207
},
92089208
}
92099209

9210-
mockVPC.EXPECT().CreateSecurityGroupRule(gomock.Any()).Return(&vpcv1.SecurityGroupRuleSecurityGroupRuleProtocolAll{Direction: ptr.To("outbound"), ID: ptr.To("ruleID")}, nil, nil)
9210+
mockVPC.EXPECT().CreateSecurityGroupRule(gomock.Any()).Return(&vpcv1.SecurityGroupRuleProtocolIcmptcpudp{Direction: ptr.To("outbound"), ID: ptr.To("ruleID")}, nil, nil)
92119211
ruleID, err := clusterScope.createVPCSecurityGroupRule(ctx, &securityGroupID, ptr.To("outbound"), &protocol, &portMin, &portMax, remote)
92129212
g.Expect(ruleID).To(BeEquivalentTo(ptr.To("ruleID")))
92139213
g.Expect(err).To(BeNil())
@@ -9548,7 +9548,7 @@ func TestCreateVPCSecurityGroupRulesAndSetStatus(t *testing.T) {
95489548
},
95499549
}
95509550

9551-
mockVPC.EXPECT().CreateSecurityGroupRule(gomock.Any()).Return(&vpcv1.SecurityGroupRuleSecurityGroupRuleProtocolAll{Direction: ptr.To("outbound"), ID: ptr.To("ruleID")}, nil, nil)
9551+
mockVPC.EXPECT().CreateSecurityGroupRule(gomock.Any()).Return(&vpcv1.SecurityGroupRuleProtocolIcmptcpudp{Direction: ptr.To("outbound"), ID: ptr.To("ruleID")}, nil, nil)
95529552
err := clusterScope.createVPCSecurityGroupRulesAndSetStatus(ctx, vpcSecurityGroup.Rules, ptr.To("securityGroupID"), ptr.To("securityGroupName"))
95539553
g.Expect(err).To(BeNil())
95549554
})

0 commit comments

Comments
 (0)