-
Notifications
You must be signed in to change notification settings - Fork 92
Closed
Labels
area/provider/ibmcloudIssues or PRs related to ibmcloud providerIssues or PRs related to ibmcloud providerkind/featureCategorizes issue or PR as related to a new feature.Categorizes issue or PR as related to a new feature.priority/important-soonMust be staffed and worked on either currently, or very soon, ideally in time for the next release.Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone
Description
/kind feature
/area provider/ibmcloud
Describe the solution you'd like
[A clear and concise description of what you want to happen.]
CAPI has now updated to contain many more helper functions which can be used in our controller to make it more standard and more readable, There are helper functions to add finalisers, to verify if the resource is paused or not and many more.
Reference to one of the controller from CAPI: cluster controller
May be we should spend some time to clean up our controller logic and make the workflow standard across various controller.
- Pass context to calling functions to derive logger.
- Use CAPI provided helper functions.
- Adopt CAPI v1beta2 changes.
- IBMPowerVSCluster controller: Adopt CAPI v1beta2 status changes and respective controller changes for IBMPowerVSCluster #2312
- IBMPowerVSMachine controller: Adopt CAPI v1beta2 status changes and respective controller changes for IBMPowerVSMachine #2272
- IBMPowerVSImage controller: Add v1beta2 changes to IBMPowerVSImage #2412
- IBMVPCCluster controller: Adopt v1beta2 conditions for IBM VPC cluster #2429
- IBMVPCMachine controller: Adopt v1beta2 conditions for IBM VPC Machine #2447
Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]
Amulyam24
Metadata
Metadata
Assignees
Labels
area/provider/ibmcloudIssues or PRs related to ibmcloud providerIssues or PRs related to ibmcloud providerkind/featureCategorizes issue or PR as related to a new feature.Categorizes issue or PR as related to a new feature.priority/important-soonMust be staffed and worked on either currently, or very soon, ideally in time for the next release.Must be staffed and worked on either currently, or very soon, ideally in time for the next release.