Update verify-boilerplate.sh to ignore ensure-golangci-lint.sh

While there, remove some legacy skipped paths and rename skipped_dirs to
reflect that it actually skips paths (including ensure-golangci-lint.sh,
which is a file, not a directory).

Author: mdbooth

hack/boilerplate/boilerplate.py

@@ -149,17 +149,20 @@ def file_passes(filename, refs, regexs):
 def file_extension(filename):
     return os.path.splitext(filename)[1].split(".")[-1].lower()
 
-skipped_dirs = ['Godeps', 'third_party', '_gopath', '_output', '.git', 'cluster/env.sh',
-                "vendor", "test/e2e/generated/bindata.go", "hack/boilerplate/test",
-                "pkg/kubectl/generated/bindata.go"]
+skipped_paths = [
+        '_output',
+        '.git',
+        # Downloaded, not our copyright
+        'hack/tools/ensure-golangci-lint.sh',
+]
 
 # list all the files contain 'DO NOT EDIT', but are not generated
-skipped_ungenerated_files = ['hack/lib/swagger.sh', 'hack/boilerplate/boilerplate.py']
+skipped_ungenerated_files = ['hack/boilerplate/boilerplate.py']
 
 def normalize_files(files):
     newfiles = []
     for pathname in files:
-        if any(x in pathname for x in skipped_dirs):
+        if any(x in pathname for x in skipped_paths):
             continue
         newfiles.append(pathname)
     for i, pathname in enumerate(newfiles):
@@ -173,12 +176,12 @@ def get_files(extensions):
         files = args.filenames
     else:
         for root, dirs, walkfiles in os.walk(args.rootdir):
-            # don't visit certain dirs. This is just a performance improvement
+            # don't visit certain paths. This is just a performance improvement
             # as we would prune these later in normalize_files(). But doing it
             # cuts down the amount of filesystem walking we do and cuts down
             # the size of the file list
-            for d in skipped_dirs:
-                if d in dirs:
+            for p in skipped_paths:
+                if p in dirs:
                     dirs.remove(d)
 
             for name in walkfiles: