Skip to content

Commit 19c3106

Browse files
committed
Move log to creating place
1 parent 2f588c1 commit 19c3106

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

controllers/openstackmachine_controller.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -287,8 +287,7 @@ func (r *OpenStackMachineReconciler) reconcileNormal(ctx context.Context, logger
287287
if err != nil {
288288
return ctrl.Result{}, err
289289
}
290-
291-
logger.Info("Creating Machine")
290+
logger.Info("Reconciling Machine create started")
292291

293292
clusterName := fmt.Sprintf("%s-%s", cluster.ObjectMeta.Namespace, cluster.Name)
294293

@@ -307,7 +306,7 @@ func (r *OpenStackMachineReconciler) reconcileNormal(ctx context.Context, logger
307306
return ctrl.Result{}, err
308307
}
309308

310-
instance, err := r.getOrCreate(computeService, machine, openStackMachine, cluster, openStackCluster, userData)
309+
instance, err := r.getOrCreate(computeService, machine, openStackMachine, cluster, openStackCluster, userData, logger)
311310
if err != nil {
312311
handleUpdateMachineError(logger, openStackMachine, errors.Errorf("OpenStack instance cannot be created: %v", err))
313312
return ctrl.Result{}, err
@@ -371,14 +370,15 @@ func (r *OpenStackMachineReconciler) reconcileNormal(ctx context.Context, logger
371370
return ctrl.Result{}, nil
372371
}
373372

374-
func (r *OpenStackMachineReconciler) getOrCreate(computeService *compute.Service, machine *clusterv1.Machine, openStackMachine *infrav1.OpenStackMachine, cluster *clusterv1.Cluster, openStackCluster *infrav1.OpenStackCluster, userData string) (*infrav1.Instance, error) {
373+
func (r *OpenStackMachineReconciler) getOrCreate(computeService *compute.Service, machine *clusterv1.Machine, openStackMachine *infrav1.OpenStackMachine, cluster *clusterv1.Cluster, openStackCluster *infrav1.OpenStackCluster, userData string, logger logr.Logger) (*infrav1.Instance, error) {
375374

376375
instance, err := computeService.InstanceExists(openStackMachine.Name)
377376
if err != nil {
378377
return nil, err
379378
}
380379

381380
if instance == nil {
381+
logger.Info("Machine not exist, Creating Machine", "Machine", openStackMachine.Name)
382382
instance, err = computeService.InstanceCreate(cluster.Name, machine, openStackMachine, openStackCluster, userData)
383383
if err != nil {
384384
return nil, errors.Errorf("error creating Openstack instance: %v", err)

0 commit comments

Comments
 (0)