Skip to content

Commit 3c067cc

Browse files
committed
Dockerfile: add the ARG defaulting within the Dockerfile
Add the default value for `GO_VERSION` within the Dockerfile to fix build checks warnings that come from an empty variable. This doesn’t break existing behavior; version control is still managed by the Makefile ``` - InvalidDefaultArgInFrom: Default value for ARG \ golang:${GO_VERSION} results in empty or invalid base image name (line 17) ``` Signed-off-by: Feruzjon Muyassarov <[email protected]>
1 parent 4380b20 commit 3c067cc

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414

1515
# Build the manager binary
1616
ARG GO_VERSION
17-
FROM golang:${GO_VERSION} AS builder
17+
FROM golang:${GO_VERSION:-1.24.7} AS builder
1818
WORKDIR /workspace
1919

2020
# Run this with docker build --build_arg goproxy=$(go env GOPROXY) to override the goproxy

0 commit comments

Comments
 (0)