Merge pull request #1324 from mercedes-benz/tobiasgiese/loop-all-gcp-zones

🌱 gce-project.sh: loop over all GCP zones during instance creation

Author: k8s-ci-robot

hack/ci/gce-project.sh

@@ -22,7 +22,6 @@ function cloud_init {
   GOOGLE_APPLICATION_CREDENTIALS=${GOOGLE_APPLICATION_CREDENTIALS:-""}
   GCP_PROJECT=${GCP_PROJECT:-""}
   GCP_REGION=${GCP_REGION:-"us-east4"}
-  GCP_ZONE=${GCP_ZONE:-"us-east4-a"}
   GCP_MACHINE_MIN_CPU_PLATFORM=${GCP_MACHINE_MIN_CPU_PLATFORM:-"Intel Cascade Lake"}
   GCP_NETWORK_NAME=${GCP_NETWORK_NAME:-"${CLUSTER_NAME}-mynetwork"}
 
@@ -40,8 +39,7 @@ function cloud_init {
 
 function init_infrastructure() {
   if [[ ${GCP_NETWORK_NAME} != "default" ]]; then
-    if ! gcloud compute networks describe "$GCP_NETWORK_NAME" --project "$GCP_PROJECT" > /dev/null;
-    then
+    if ! gcloud compute networks describe "$GCP_NETWORK_NAME" --project "$GCP_PROJECT" >/dev/null; then
       gcloud compute networks create --project "$GCP_PROJECT" "$GCP_NETWORK_NAME" --subnet-mode custom
       gcloud compute networks subnets create "$GCP_NETWORK_NAME" --project "$GCP_PROJECT" \
         --network="$GCP_NETWORK_NAME" --range="$PRIVATE_NETWORK_CIDR" --region "$GCP_REGION"
@@ -66,17 +64,15 @@ function init_infrastructure() {
   gcloud compute networks list --project="$GCP_PROJECT"
   gcloud compute networks describe "$GCP_NETWORK_NAME" --project="$GCP_PROJECT"
 
-  if ! gcloud compute routers describe "${CLUSTER_NAME}-myrouter" --project="$GCP_PROJECT" --region="$GCP_REGION" > /dev/null;
-  then
+  if ! gcloud compute routers describe "${CLUSTER_NAME}-myrouter" --project="$GCP_PROJECT" --region="$GCP_REGION" >/dev/null; then
     gcloud compute routers create "${CLUSTER_NAME}-myrouter" --project="$GCP_PROJECT" \
-    --region="$GCP_REGION" --network="$GCP_NETWORK_NAME"
+      --region="$GCP_REGION" --network="$GCP_NETWORK_NAME"
   fi
   if ! gcloud compute routers nats describe --router="$CLUSTER_NAME-myrouter" "$CLUSTER_NAME-mynat" \
-    --project="$GCP_PROJECT" --region="${GCP_REGION}" > /dev/null;
-  then
-  gcloud compute routers nats create "${CLUSTER_NAME}-mynat" --project="$GCP_PROJECT" \
-    --router-region="$GCP_REGION" --router="${CLUSTER_NAME}-myrouter" \
-    --nat-all-subnet-ip-ranges --auto-allocate-nat-external-ips
+    --project="$GCP_PROJECT" --region="${GCP_REGION}" >/dev/null; then
+    gcloud compute routers nats create "${CLUSTER_NAME}-mynat" --project="$GCP_PROJECT" \
+      --router-region="$GCP_REGION" --router="${CLUSTER_NAME}-myrouter" \
+      --nat-all-subnet-ip-ranges --auto-allocate-nat-external-ips
   fi
 }
 
@@ -92,49 +88,56 @@ function create_vm {
   local diskname="${CLUSTER_NAME}-disk"
   local imagename="${servername}-image"
 
-  # Create the base disk image based on the public Ubuntu 20.04 LTS cloud image
-  # Note that this has also been verified to work with CentOS 8 as of
-  # 2021-01-12, but this is not tested regularly.
-  # To use CentOS 8:
-  #   --image-project centos-cloud --image-family centos-stream-8
-  if ! gcloud compute disks describe "$diskname" --project "$GCP_PROJECT" --zone "$GCP_ZONE" > /dev/null;
-  then
-    gcloud compute disks create "$diskname" \
-      --project "$GCP_PROJECT" \
-      --image-project ubuntu-os-cloud --image-family ubuntu-2004-lts \
-      --zone "$GCP_ZONE"
-  fi
-
-  if ! gcloud compute images describe "$imagename" --project "$GCP_PROJECT" > /dev/null;
-  then
-    gcloud compute images create "$imagename" \
-      --project "$GCP_PROJECT" \
-      --source-disk "$diskname" --source-disk-zone "$GCP_ZONE" \
-      --licenses "https://www.googleapis.com/compute/v1/projects/vm-options/global/licenses/enable-vmx"
-  fi
+  # Loop over all zones in the GCP region to ignore a full zone.
+  # We are not able to use 'gcloud compute zones list' as the gcloud.compute.zones.list permission is missing.
+  for GCP_ZONE in "${GCP_REGION}-a" "${GCP_REGION}-b" "${GCP_REGION}-c"; do
+    # Check if image was already created.
+    # Images are not zone specific, but the disk is.
+    if ! gcloud compute images describe "$imagename" --project "$GCP_PROJECT" >/dev/null; then
+      # Create the base disk image based on the public Ubuntu 20.04 LTS cloud image
+      # Note that this has also been verified to work with CentOS 8 as of
+      # 2021-01-12, but this is not tested regularly.
+      # To use CentOS 8:
+      #   --image-project centos-cloud --image-family centos-stream-8
+      if ! gcloud compute disks describe "$diskname" --project "$GCP_PROJECT" --zone "$GCP_ZONE" >/dev/null; then
+        gcloud compute disks create "$diskname" \
+          --project "$GCP_PROJECT" \
+          --image-project ubuntu-os-cloud --image-family ubuntu-2004-lts \
+          --zone "$GCP_ZONE"
+      fi
+      gcloud compute images create "$imagename" \
+        --project "$GCP_PROJECT" \
+        --source-disk "$diskname" --source-disk-zone "$GCP_ZONE" \
+        --licenses "https://www.googleapis.com/compute/v1/projects/vm-options/global/licenses/enable-vmx"
+    fi
 
-  if ! gcloud compute instances describe "$servername" --project "$GCP_PROJECT" --zone "$GCP_ZONE" > /dev/null;
-  then
-    gcloud compute instances create "$servername" \
-      --project "$GCP_PROJECT" \
-      --zone "$GCP_ZONE" \
-      --image "$imagename" \
-      --boot-disk-size 200G \
-      --boot-disk-type pd-ssd \
-      --can-ip-forward \
-      --tags http-server,https-server,novnc,openstack-apis \
-      --min-cpu-platform "$GCP_MACHINE_MIN_CPU_PLATFORM" \
-      --machine-type "$machine_type" \
-      --network-interface="private-network-ip=${ip},network=${CLUSTER_NAME}-mynetwork,subnet=${CLUSTER_NAME}-mynetwork" \
-      --metadata-from-file user-data="$userdata"
-  fi
+    if ! gcloud compute instances describe "$servername" --project "$GCP_PROJECT" --zone "$GCP_ZONE" >/dev/null; then
+      if gcloud compute instances create "$servername" \
+        --project "$GCP_PROJECT" \
+        --zone "$GCP_ZONE" \
+        --image "$imagename" \
+        --boot-disk-size 200G \
+        --boot-disk-type pd-ssd \
+        --can-ip-forward \
+        --tags http-server,https-server,novnc,openstack-apis \
+        --min-cpu-platform "$GCP_MACHINE_MIN_CPU_PLATFORM" \
+        --machine-type "$machine_type" \
+        --network-interface="private-network-ip=${ip},network=${CLUSTER_NAME}-mynetwork,subnet=${CLUSTER_NAME}-mynetwork" \
+        --metadata-from-file user-data="$userdata"; then
+        # return function create_vm if the instance have been created successfully.
+        return
+      fi
+    fi
+  done
+  echo "No free GCP zone could be found to create instance $servername."
+  exit 1
 }
 
 function get_public_ip {
   local ip
   while ! ip=$(gcloud compute instances describe "${CLUSTER_NAME}-controller" \
-          --project "$GCP_PROJECT" --zone "$GCP_ZONE" \
-          --format='get(networkInterfaces[0].accessConfigs[0].natIP)'); do
+    --project "$GCP_PROJECT" --zone "$GCP_ZONE" \
+    --format='get(networkInterfaces[0].accessConfigs[0].natIP)'); do
     echo "Waiting for a public IP"
     sleep 5
   done