unit tests: add cases for nil network and SG override

Signed-off-by: Bharath Nallapeta <[email protected]>

Author: bnallapeta

controllers/openstackmachine_controller_test.go

@@ -77,20 +77,17 @@ func TestOpenStackMachineSpecToOpenStackServerSpec(t *testing.T) {
 		},
 	}
 	portOptsWithAdditionalSecurityGroup := []infrav1.PortOpts{
-		{
-			Network: &infrav1.NetworkParam{
-				ID: ptr.To(openStackCluster.Status.Network.ID),
-			},
-			SecurityGroups: []infrav1.SecurityGroupParam{
-				{
-					ID: ptr.To(openStackCluster.Status.WorkerSecurityGroup.ID),
-				},
-				{
-					ID: ptr.To(extraSecurityGroupUUID),
-				},
-			},
-		},
-	}
+        {
+            Network: &infrav1.NetworkParam{
+                ID: ptr.To(openStackCluster.Status.Network.ID),
+            },
+            SecurityGroups: []infrav1.SecurityGroupParam{
+                {
+                    ID: ptr.To(extraSecurityGroupUUID),
+                },
+            },
+        },
+    }
 	image := infrav1.ImageParam{Filter: &infrav1.ImageFilter{Name: ptr.To("my-image")}}
 	tags := []string{"tag1", "tag2"}
 	userData := &corev1.LocalObjectReference{Name: "server-data-secret"}
@@ -158,27 +155,67 @@ func TestOpenStackMachineSpecToOpenStackServerSpec(t *testing.T) {
 			},
 		},
 		{
-			name: "Test an OpenStackMachineSpec to OpenStackServerSpec conversion with flavorID specified but not flavor",
-			spec: &infrav1.OpenStackMachineSpec{
-				FlavorID:   ptr.To(flavorUUID),
-				Image:      image,
-				SSHKeyName: sshKeyName,
-			},
-			want: &infrav1alpha1.OpenStackServerSpec{
-				FlavorID:    ptr.To(flavorUUID),
-				IdentityRef: identityRef,
-				Image:       image,
-				SSHKeyName:  sshKeyName,
-				Ports:       portOpts,
-				Tags:        tags,
-				UserDataRef: userData,
-			},
-		},
+            name: "Test an OpenStackMachineSpec to OpenStackServerSpec conversion with flavorID specified but not flavor",
+            spec: &infrav1.OpenStackMachineSpec{
+                FlavorID:   ptr.To(flavorUUID),
+                Image:      image,
+                SSHKeyName: sshKeyName,
+            },
+            want: &infrav1alpha1.OpenStackServerSpec{
+                FlavorID:    ptr.To(flavorUUID),
+                IdentityRef: identityRef,
+                Image:       image,
+                SSHKeyName:  sshKeyName,
+                Ports:       portOpts,
+                Tags:        tags,
+                UserDataRef: userData,
+            },
+        },
+        {
+            name: "Cluster network nil, machine defines port network and overrides SG",
+            spec: &infrav1.OpenStackMachineSpec{
+                Ports: []infrav1.PortOpts{{
+                    Network: &infrav1.NetworkParam{ID: ptr.To(networkUUID)},
+                }},
+                SecurityGroups: []infrav1.SecurityGroupParam{{ID: ptr.To(extraSecurityGroupUUID)}},
+            },
+            want: &infrav1alpha1.OpenStackServerSpec{
+                IdentityRef: identityRef,
+                Ports: []infrav1.PortOpts{{
+                    Network: &infrav1.NetworkParam{ID: ptr.To(networkUUID)},
+                    SecurityGroups: []infrav1.SecurityGroupParam{{ID: ptr.To(extraSecurityGroupUUID)}},
+                }},
+                Tags:        tags,
+                UserDataRef: userData,
+            },
+        },
+        {
+            name: "Cluster network nil, machine defines port network and falls back to cluster SG",
+            spec: &infrav1.OpenStackMachineSpec{
+                Ports: []infrav1.PortOpts{{
+                    Network: &infrav1.NetworkParam{ID: ptr.To(networkUUID)},
+                }},
+            },
+            want: &infrav1alpha1.OpenStackServerSpec{
+                IdentityRef: identityRef,
+                Ports: []infrav1.PortOpts{{
+                    Network: &infrav1.NetworkParam{ID: ptr.To(networkUUID)},
+                    SecurityGroups: []infrav1.SecurityGroupParam{{ID: ptr.To(workerSecurityGroupUUID)}},
+                }},
+                Tags:        tags,
+                UserDataRef: userData,
+            },
+        },
 	}
 	for i := range tests {
 		tt := tests[i]
 		t.Run(tt.name, func(t *testing.T) {
-			spec := openStackMachineSpecToOpenStackServerSpec(tt.spec, identityRef, tags, "", userData, &openStackCluster.Status.WorkerSecurityGroup.ID, openStackCluster.Status.Network.ID)
+			defaultNetID := ""
+			if openStackCluster.Status.Network != nil {
+				defaultNetID = openStackCluster.Status.Network.ID
+			}
+
+			spec := openStackMachineSpecToOpenStackServerSpec(tt.spec, identityRef, tags, "", userData, &openStackCluster.Status.WorkerSecurityGroup.ID, defaultNetID)
 			if !reflect.DeepEqual(spec, tt.want) {
 				t.Errorf("openStackMachineSpecToOpenStackServerSpec() got = %+v, want %+v", spec, tt.want)
 			}