Skip to content

Commit 7e4e4a8

Browse files
sbueringerk8s-ci-robot
authored andcommitted
Pr v1alpha2 further refactorings (#455)
* further refactorings for v1alpha2 * test fix & define targets for prow * regen & fix typo in log message * fix tests * fix gen examples * minor renaming, * nil pointer fix * implement machinedeployment * fix tests * review fixes
1 parent b5fe8bc commit 7e4e4a8

File tree

64 files changed

+1615
-685
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

64 files changed

+1615
-685
lines changed

.dockerignore

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
.git
2+
.github
3+
.vscode
4+
bin/
5+
config/
6+
hack/
7+
docs/
8+
examples/
9+
**/.md

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,7 @@ network_closure.sh
9696

9797
# User cluster configs
9898
.kubeconfig
99+
kubeconfig
99100

100101
.tags*
101102

.golangci.yml

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
linters:
2+
enable:
3+
- golint
4+
- govet
5+
- gofmt
6+
- structcheck
7+
- varcheck
8+
- interfacer
9+
- unconvert
10+
- ineffassign
11+
- goconst
12+
- misspell
13+
- nakedret
14+
- prealloc
15+
- deadcode
16+
disable-all: true
17+
# Run with --fast=false for more extensive checks
18+
fast: true
19+
issue:
20+
max-same-issues: 0
21+
max-per-linter: 0

Dockerfile

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -41,20 +41,19 @@
4141
# Build the manager binary
4242
FROM golang:1.12.9
4343

44-
# default the go proxy
44+
# Run this with docker build --build_arg $(go env GOPROXY) to override the goproxy
4545
ARG goproxy=https://proxy.golang.org
46-
47-
# run this with docker build --build_arg $(go env GOPROXY) to override the goproxy
4846
ENV GOPROXY=$goproxy
4947

5048
WORKDIR /workspace
49+
# Copy the Go Modules manifests
5150
COPY go.mod go.mod
5251
COPY go.sum go.sum
53-
# cache deps before building and copying source so that we don't need to re-download as much
52+
# Cache deps before building and copying source so that we don't need to re-download as much
5453
# and so that source changes don't invalidate our downloaded layer
5554
RUN go mod download
5655

57-
# Copy the go source
56+
# Copy the sources
5857
COPY main.go main.go
5958
COPY api/ api/
6059
COPY controllers/ controllers/

0 commit comments

Comments
 (0)