Merge pull request #1012 from jichenjc/add_webhook_new

✨Allow update for some param only first time update

Author: k8s-ci-robot

api/v1alpha4/openstackcluster_webhook.go

@@ -88,9 +88,15 @@ func (r *OpenStackCluster) ValidateUpdate(old runtime.Object) error {
 	newOpenStackClusterSpec := newOpenStackCluster["spec"].(map[string]interface{})
 	oldOpenStackClusterSpec := oldOpenStackCluster["spec"].(map[string]interface{})
 
-	// allow changes to ControlPlaneEndpoint
-	delete(oldOpenStackClusterSpec, "controlPlaneEndpoint")
-	delete(newOpenStackClusterSpec, "controlPlaneEndpoint")
+	// get controlPlaneEndpoint, something like {"host":"", "port":""}
+	cpe := oldOpenStackClusterSpec["controlPlaneEndpoint"].(map[string]interface{})
+
+	// allow change only for the first time
+	host, ok := cpe["host"].(string)
+	if ok && len(host) == 0 {
+		delete(oldOpenStackClusterSpec, "controlPlaneEndpoint")
+		delete(newOpenStackClusterSpec, "controlPlaneEndpoint")
+	}
 
 	if !reflect.DeepEqual(oldOpenStackClusterSpec, newOpenStackClusterSpec) {
 		allErrs = append(allErrs, field.Forbidden(field.NewPath("spec"), "cannot be modified"))

api/v1alpha4/openstackmachine_webhook.go

@@ -88,13 +88,17 @@ func (r *OpenStackMachine) ValidateUpdate(old runtime.Object) error {
 	newOpenStackMachineSpec := newOpenStackMachine["spec"].(map[string]interface{})
 	oldOpenStackMachineSpec := oldOpenStackMachine["spec"].(map[string]interface{})
 
-	// allow changes to providerID
-	delete(oldOpenStackMachineSpec, "providerID")
-	delete(newOpenStackMachineSpec, "providerID")
+	// allow changes to providerID once
+	if oldOpenStackMachineSpec["providerID"] == nil {
+		delete(oldOpenStackMachineSpec, "providerID")
+		delete(newOpenStackMachineSpec, "providerID")
+	}
 
-	// allow changes to instanceID
-	delete(oldOpenStackMachineSpec, "instanceID")
-	delete(newOpenStackMachineSpec, "instanceID")
+	// allow changes to instanceID once
+	if oldOpenStackMachineSpec["instanceID"] == nil {
+		delete(oldOpenStackMachineSpec, "instanceID")
+		delete(newOpenStackMachineSpec, "instanceID")
+	}
 
 	if !reflect.DeepEqual(oldOpenStackMachineSpec, newOpenStackMachineSpec) {
 		allErrs = append(allErrs, field.Forbidden(field.NewPath("spec"), "cannot be modified"))