Skip to content

Commit 821a1a2

Browse files
authored
Merge pull request #1744 from teran/fix/lost-endpoint-type
🐛Fix missing endpoint type in OpenStack endpoint clients configuration
2 parents 24c0f0c + 2909ce5 commit 821a1a2

File tree

6 files changed

+11
-5
lines changed

6 files changed

+11
-5
lines changed

pkg/clients/compute.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,8 @@ type computeClient struct{ client *gophercloud.ServiceClient }
6767
// NewComputeClient returns a new compute client.
6868
func NewComputeClient(providerClient *gophercloud.ProviderClient, providerClientOpts *clientconfig.ClientOpts) (ComputeClient, error) {
6969
compute, err := openstack.NewComputeV2(providerClient, gophercloud.EndpointOpts{
70-
Region: providerClientOpts.RegionName,
70+
Region: providerClientOpts.RegionName,
71+
Availability: clientconfig.GetEndpointType(providerClientOpts.EndpointType),
7172
})
7273
if err != nil {
7374
return nil, fmt.Errorf("failed to create compute service client: %v", err)

pkg/clients/image.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,8 @@ type imageClient struct{ client *gophercloud.ServiceClient }
3636
// NewImageClient returns a new glance client.
3737
func NewImageClient(providerClient *gophercloud.ProviderClient, providerClientOpts *clientconfig.ClientOpts) (ImageClient, error) {
3838
images, err := openstack.NewImageServiceV2(providerClient, gophercloud.EndpointOpts{
39-
Region: providerClientOpts.RegionName,
39+
Region: providerClientOpts.RegionName,
40+
Availability: clientconfig.GetEndpointType(providerClientOpts.EndpointType),
4041
})
4142
if err != nil {
4243
return nil, fmt.Errorf("failed to create image service client: %v", err)

pkg/clients/loadbalancer.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,8 @@ type lbClient struct {
6464
// NewLbClient returns a new loadbalancer client.
6565
func NewLbClient(providerClient *gophercloud.ProviderClient, providerClientOpts *clientconfig.ClientOpts) (LbClient, error) {
6666
loadbalancerClient, err := openstack.NewLoadBalancerV2(providerClient, gophercloud.EndpointOpts{
67-
Region: providerClientOpts.RegionName,
67+
Region: providerClientOpts.RegionName,
68+
Availability: clientconfig.GetEndpointType(providerClientOpts.EndpointType),
6869
})
6970
if err != nil {
7071
return nil, fmt.Errorf("failed to create load balancer service client: %v", err)

pkg/clients/networking.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,8 @@ type networkClient struct {
9696
// NewNetworkClient returns an instance of the networking service.
9797
func NewNetworkClient(providerClient *gophercloud.ProviderClient, providerClientOpts *clientconfig.ClientOpts) (NetworkClient, error) {
9898
serviceClient, err := openstack.NewNetworkV2(providerClient, gophercloud.EndpointOpts{
99-
Region: providerClientOpts.RegionName,
99+
Region: providerClientOpts.RegionName,
100+
Availability: clientconfig.GetEndpointType(providerClientOpts.EndpointType),
100101
})
101102
if err != nil {
102103
return nil, fmt.Errorf("failed to create networking service providerClient: %v", err)

pkg/clients/volume.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,8 @@ type volumeClient struct{ client *gophercloud.ServiceClient }
3939
// NewVolumeClient returns a new cinder client.
4040
func NewVolumeClient(providerClient *gophercloud.ProviderClient, providerClientOpts *clientconfig.ClientOpts) (VolumeClient, error) {
4141
volume, err := openstack.NewBlockStorageV3(providerClient, gophercloud.EndpointOpts{
42-
Region: providerClientOpts.RegionName,
42+
Region: providerClientOpts.RegionName,
43+
Availability: clientconfig.GetEndpointType(providerClientOpts.EndpointType),
4344
})
4445
if err != nil {
4546
return nil, fmt.Errorf("failed to create volume service client: %v", err)

pkg/scope/provider.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -198,6 +198,7 @@ func NewProviderClient(cloud clientconfig.Cloud, caCert []byte, logger logr.Logg
198198
clientOpts.AuthInfo = cloud.AuthInfo
199199
clientOpts.AuthType = cloud.AuthType
200200
clientOpts.RegionName = cloud.RegionName
201+
clientOpts.EndpointType = cloud.EndpointType
201202
}
202203

203204
opts, err := clientconfig.AuthOptions(clientOpts)

0 commit comments

Comments
 (0)