Fix a lint issue on image reconcile

EmilienM · EmilienM · commit 8312b120f5f7 · 2025-03-05T09:35:48.000-05:00
diff --git a/internal/controllers/image/reconcile.go b/internal/controllers/image/reconcile.go
@@ -219,9 +219,8 @@ func (r *orcImageReconciler) reconcileNormal(ctx context.Context, orcImage *orcv
 			addStatus(withIncrementDownloadAttempts())
 
 			return ctrl.Result{}, nil
-		} else {
-			return ctrl.Result{}, r.uploadImageContent(ctx, orcImage, imageClient, glanceImage)
 		}
+		return ctrl.Result{}, r.uploadImageContent(ctx, orcImage, imageClient, glanceImage)
 
 	// Error cases
 	case images.ImageStatusKilled:

Original file line number	Diff line number	Diff line change
`@@ -219,9 +219,8 @@ func (r orcImageReconciler) reconcileNormal(ctx context.Context, orcImage orcv`
`219`	`219`	`addStatus(withIncrementDownloadAttempts())`
`220`	`220`
`221`	`221`	`return ctrl.Result{}, nil`
`222`		`- } else {`
`223`		`- return ctrl.Result{}, r.uploadImageContent(ctx, orcImage, imageClient, glanceImage)`
`224`	`222`	`}`
	`223`	`+ return ctrl.Result{}, r.uploadImageContent(ctx, orcImage, imageClient, glanceImage)`
`225`	`224`
`226`	`225`	`// Error cases`
`227`	`226`	`case images.ImageStatusKilled:`