Skip to content

Commit afe5683

Browse files
committed
Update external approvers
For a long time, in addition to the CAPO maintainers we have also allowed approvals from: - sig-cluster-lifecycle-leads - cluster-api-admins - cluster-api-maintainers However, we have to maintain these lists manually and our record of doing this has not been good. In practise there is also significant overlap in these groups. As far as I am aware this facility has never been used, but it is easy to imagine a circumstance where it might be useful, e.g. a centrally coordinated CVE affecting multiple providers urgently. Allowing commits from sig-cluster-lifecycle-leads should cover this use case in practise, and removing the other 2 lists reduces the amount of copy/paste we need to maintain from other projects.
1 parent 9233490 commit afe5683

File tree

2 files changed

+9
-15
lines changed

2 files changed

+9
-15
lines changed

OWNERS

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@
22

33
approvers:
44
- sig-cluster-lifecycle-leads
5-
- cluster-api-admins
6-
- cluster-api-maintainers
75
- cluster-api-openstack-maintainers
86

97
reviewers:

OWNERS_ALIASES

Lines changed: 9 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -7,23 +7,19 @@
77
# - https://github.com/kubernetes/k8s.io/blob/main/groups/sig-cluster-lifecycle/groups.yaml
88

99
aliases:
10-
# correct as of 2021/03/03
10+
# sig-cluster-lifecycle-leads are included as approvers in case it's ever
11+
# operationally expedient:
12+
# Source:
13+
# https://github.com/kubernetes/org/blob/main/config/kubernetes/sig-cluster-lifecycle/teams.yaml
14+
# correct as of 2023/05/10
1115
sig-cluster-lifecycle-leads:
12-
- justinsb
13-
- neolit123
14-
- timothysc
16+
members:
17+
- CecileRobertMichon
1518
- fabriziopandini
16-
# correct as of 2021/03/03
17-
cluster-api-admins:
18-
- justinsb
19-
- detiber
20-
- vincepri
21-
# correct as of 2021/03/03
22-
cluster-api-maintainers:
2319
- justinsb
24-
- detiber
20+
- neolit123
2521
- vincepri
26-
- CecileRobertMichon
22+
2723
cluster-api-openstack-maintainers:
2824
- jichenjc
2925
- mdbooth

0 commit comments

Comments
 (0)