Reenable SA1019 in staticcheck linter

Author: mdbooth

.golangci.yml

@@ -168,10 +168,6 @@ issues:
     - stylecheck
     text: "ST1003: should not use underscores in Go names;"
     path: .*(api|types)\/.*\/.*conversion.*\.go$
-  # Can be drop once kubernetes-sigs/cluster-api-provider-openstack#1326 is done.
-  - linters:
-    - staticcheck
-    text: "SA1019"
 
 run:
   timeout: 10m

pkg/cloud/services/compute/instance_test.go

@@ -1174,7 +1174,7 @@ func TestService_normalizePorts(t *testing.T) {
 							},
 						},
 					},
-					Trunk: pointer.BoolPtr(false),
+					Trunk: pointer.Bool(false),
 				},
 			},
 		},
@@ -1198,7 +1198,7 @@ func TestService_normalizePorts(t *testing.T) {
 							},
 						},
 					},
-					Trunk: pointer.BoolPtr(false),
+					Trunk: pointer.Bool(false),
 				},
 			},
 		},
@@ -1223,7 +1223,7 @@ func TestService_normalizePorts(t *testing.T) {
 							},
 						},
 					},
-					Trunk: pointer.BoolPtr(true),
+					Trunk: pointer.Bool(true),
 				},
 			},
 		},
@@ -1233,7 +1233,7 @@ func TestService_normalizePorts(t *testing.T) {
 				{
 					Network:  &infrav1.NetworkFilter{},
 					FixedIPs: nil,
-					Trunk:    pointer.BoolPtr(true),
+					Trunk:    pointer.Bool(true),
 				},
 			},
 			want: []infrav1.PortOpts{
@@ -1248,7 +1248,7 @@ func TestService_normalizePorts(t *testing.T) {
 							},
 						},
 					},
-					Trunk: pointer.BoolPtr(true),
+					Trunk: pointer.Bool(true),
 				},
 			},
 		},
@@ -1266,7 +1266,7 @@ func TestService_normalizePorts(t *testing.T) {
 					Network: &infrav1.NetworkFilter{
 						ID: networkID,
 					},
-					Trunk: pointer.BoolPtr(false),
+					Trunk: pointer.Bool(false),
 				},
 			},
 		},
@@ -1290,7 +1290,7 @@ func TestService_normalizePorts(t *testing.T) {
 						ID:   networkID,
 						Name: "test-network",
 					},
-					Trunk: pointer.BoolPtr(false),
+					Trunk: pointer.Bool(false),
 				},
 			},
 		},
@@ -1322,7 +1322,7 @@ func TestService_normalizePorts(t *testing.T) {
 							},
 						},
 					},
-					Trunk: pointer.BoolPtr(false),
+					Trunk: pointer.Bool(false),
 				},
 			},
 		},
@@ -1357,7 +1357,7 @@ func TestService_normalizePorts(t *testing.T) {
 							},
 						},
 					},
-					Trunk: pointer.BoolPtr(false),
+					Trunk: pointer.Bool(false),
 				},
 			},
 		},
@@ -1445,7 +1445,7 @@ func TestService_normalizePorts(t *testing.T) {
 							},
 						},
 					},
-					Trunk: pointer.BoolPtr(false),
+					Trunk: pointer.Bool(false),
 				},
 			},
 		},