Merge pull request #1531 from dulek/double-event

k8s-ci-robot · web-flow · commit b7af95893130 · 2023-04-27T07:24:16.000-07:00
🌱 Remove creation of 2 Events for the same event
diff --git a/pkg/cloud/services/loadbalancer/loadbalancer.go b/pkg/cloud/services/loadbalancer/loadbalancer.go
@@ -368,8 +368,7 @@ func (s *Service) getOrCreateMonitor(openStackCluster *infrav1.OpenStackCluster,
 	monitor, err = s.loadbalancerClient.CreateMonitor(monitorCreateOpts)
 	// Skip creating monitor if it is not supported by Octavia provider
 	if capoerrors.IsNotImplementedError(err) {
-		record.Warnf(openStackCluster, "SkippedCreateMonitor", "Health monitors are not supported with the current Octavia provider.")
-		record.Eventf(openStackCluster, "SkippedCreateMonitor", "Health Monitor is not created as it's not implemented with the current Octavia provider.")
+		record.Warnf(openStackCluster, "SkippedCreateMonitor", "Health Monitor is not created as it's not implemented with the current Octavia provider.")
 		return nil
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -368,8 +368,7 @@ func (s Service) getOrCreateMonitor(openStackCluster infrav1.OpenStackCluster,`
`368`	`368`	`monitor, err = s.loadbalancerClient.CreateMonitor(monitorCreateOpts)`
`369`	`369`	`// Skip creating monitor if it is not supported by Octavia provider`
`370`	`370`	`if capoerrors.IsNotImplementedError(err) {`
`371`		`- record.Warnf(openStackCluster, "SkippedCreateMonitor", "Health monitors are not supported with the current Octavia provider.")`
`372`		`- record.Eventf(openStackCluster, "SkippedCreateMonitor", "Health Monitor is not created as it's not implemented with the current Octavia provider.")`
	`371`	`+ record.Warnf(openStackCluster, "SkippedCreateMonitor", "Health Monitor is not created as it's not implemented with the current Octavia provider.")`
`373`	`372`	`return nil`
`374`	`373`	`}`
`375`	`374`