Skip to content

Commit d5ed89e

Browse files
committed
Consolidate test names
It should start with lowercase, and should not include the redundant `It`.
1 parent a6bce16 commit d5ed89e

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

test/e2e/suites/e2e/e2e_test.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ var _ = Describe("e2e tests [PR-Blocking]", func() {
8585
})
8686

8787
Describe("Workload cluster (default)", func() {
88-
It("It should be creatable and deletable", func() {
88+
It("should be creatable and deletable", func() {
8989
shared.Logf("Creating a cluster")
9090
clusterName := fmt.Sprintf("cluster-%s", namespace.Name)
9191
configCluster := defaultConfigCluster(clusterName, namespace.Name)
@@ -206,7 +206,7 @@ var _ = Describe("e2e tests [PR-Blocking]", func() {
206206
})
207207

208208
Describe("Workload cluster (without lb)", func() {
209-
It("Should create port(s) with custom options", func() {
209+
It("should create port(s) with custom options", func() {
210210
shared.Logf("Creating a cluster")
211211
clusterName := fmt.Sprintf("cluster-%s", namespace.Name)
212212
configCluster := defaultConfigCluster(clusterName, namespace.Name)
@@ -526,7 +526,7 @@ var _ = Describe("e2e tests [PR-Blocking]", func() {
526526
})
527527

528528
Describe("MachineDeployment misconfigurations", func() {
529-
It("Should fail to create MachineDeployment with invalid subnet or invalid availability zone", func() {
529+
It("should fail to create MachineDeployment with invalid subnet or invalid availability zone", func() {
530530
shared.Logf("Creating a cluster")
531531
clusterName := fmt.Sprintf("cluster-%s", namespace.Name)
532532
configCluster := defaultConfigCluster(clusterName, namespace.Name)
@@ -594,7 +594,7 @@ var _ = Describe("e2e tests [PR-Blocking]", func() {
594594
Expect(err).NotTo(HaveOccurred())
595595
})
596596

597-
It("It should be creatable and deletable", func() {
597+
It("should be creatable and deletable", func() {
598598
workerMachines := framework.GetMachinesByMachineDeployments(ctx, framework.GetMachinesByMachineDeploymentsInput{
599599
Lister: e2eCtx.Environment.BootstrapClusterProxy.GetClient(),
600600
ClusterName: clusterName,

0 commit comments

Comments
 (0)