Skip to content

Commit e22c52f

Browse files
authored
Merge pull request #1498 from mnaser/bump-micro-version
🐛 fix: allow using multiattach volume types
2 parents c06146b + 2df3778 commit e22c52f

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ Each version of Cluster API for OpenStack will attempt to support two Kubernetes
7979
**NOTE:** As the versioning for this project is tied to the versioning of Cluster API, future modifications to this
8080
policy may be made to more closely aligned with other providers in the Cluster API ecosystem.
8181

82-
**NOTE:** The minimum microversion of CAPI using nova is `2.53` now due to `server tags` support, see [code](https://github.com/kubernetes-sigs/cluster-api-provider-openstack/blob/c052e7e600f0e5ebddc839c08746bb636e79be87/pkg/cloud/services/compute/service.go#L38) for additional information.
82+
**NOTE:** The minimum microversion of CAPI using nova is `2.60` now due to `server tags` support as well permitting `multiattach` volume types, see [code](https://github.com/kubernetes-sigs/cluster-api-provider-openstack/blob/c052e7e600f0e5ebddc839c08746bb636e79be87/pkg/cloud/services/compute/service.go#L38) for additional information.
8383

8484
**NOTE:** We require Keystone v3 for authentication.
8585

pkg/clients/compute.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,14 +33,15 @@ import (
3333

3434
/*
3535
NovaMinimumMicroversion is the minimum Nova microversion supported by CAPO
36-
2.53 corresponds to OpenStack Pike
36+
2.60 corresponds to OpenStack Queens
3737
3838
For the canonical description of Nova microversions, see
3939
https://docs.openstack.org/nova/latest/reference/api-microversion-history.html
4040
4141
CAPO uses server tags, which were added in microversion 2.52.
42+
CAPO supports multiattach volume types, which were added in microversion 2.60.
4243
*/
43-
const NovaMinimumMicroversion = "2.53"
44+
const NovaMinimumMicroversion = "2.60"
4445

4546
// ServerExt is the base gophercloud Server with extensions used by InstanceStatus.
4647
type ServerExt struct {

0 commit comments

Comments
 (0)