ignore router get return 404 error

Author: jichenjc

pkg/cloud/services/networking/network.go

@@ -19,6 +19,7 @@ package networking
 import (
 	"fmt"
 	"sigs.k8s.io/cluster-api-provider-openstack/pkg/record"
+	capierrors "sigs.k8s.io/cluster-api-provider-openstack/pkg/utils/errors"
 
 	"github.com/gophercloud/gophercloud"
 	"github.com/gophercloud/gophercloud/openstack/networking/v2/extensions/attributestags"
@@ -213,6 +214,9 @@ func (s *Service) existsNetwork(networkID string) (bool, error) {
 	}
 	network, err := networks.Get(s.client, networkID).Extract()
 	if err != nil {
+		if capierrors.IsNotFound(err) {
+			return false, nil
+		}
 		return false, err
 	}
 	if network == nil {

pkg/cloud/services/networking/router.go

@@ -20,6 +20,7 @@ import (
 	"fmt"
 	"github.com/gophercloud/gophercloud/openstack/networking/v2/networks"
 	"sigs.k8s.io/cluster-api-provider-openstack/pkg/record"
+	"sigs.k8s.io/cluster-api-provider-openstack/pkg/utils/errors"
 
 	"github.com/gophercloud/gophercloud"
 	"github.com/gophercloud/gophercloud/openstack/networking/v2/extensions/attributestags"
@@ -281,6 +282,9 @@ func (s *Service) existsRouter(routerID string) (bool, error) {
 	}
 	router, err := routers.Get(s.client, routerID).Extract()
 	if err != nil {
+		if errors.IsNotFound(err) {
+			return false, nil
+		}
 		return false, err
 	}
 	if router == nil {

pkg/cloud/services/networking/securitygroups.go

@@ -18,6 +18,7 @@ package networking
 
 import (
 	"fmt"
+
 	"github.com/gophercloud/gophercloud/openstack/networking/v2/extensions/security/groups"
 	"github.com/gophercloud/gophercloud/openstack/networking/v2/extensions/security/rules"
 	infrav1 "sigs.k8s.io/cluster-api-provider-openstack/api/v1alpha3"

pkg/utils/errors/errors.go

@@ -0,0 +1,55 @@
+/*
+Copyright 2020 The Kubernetes Authors.
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package errors
+
+import (
+	"net/http"
+
+	"github.com/gophercloud/gophercloud"
+)
+
+func IsNotFound(err error) bool {
+	if _, ok := err.(gophercloud.ErrDefault404); ok {
+		return true
+	}
+
+	if _, ok := err.(gophercloud.ErrResourceNotFound); ok {
+		return true
+	}
+
+	if errCode, ok := err.(gophercloud.ErrUnexpectedResponseCode); ok {
+		if errCode.Actual == http.StatusNotFound {
+			return true
+		}
+	}
+
+	return false
+}
+
+func IsInvalidError(err error) bool {
+	if _, ok := err.(gophercloud.ErrDefault400); ok {
+		return true
+	}
+
+	if errCode, ok := err.(gophercloud.ErrUnexpectedResponseCode); ok {
+		if errCode.Actual == http.StatusBadRequest {
+			return true
+		}
+	}
+
+	return false
+}