Optional Bool Fields Omitted During v1alpha7 → v1beta1 Conversion

[okozachenko1203]

/kind bug

What steps did you take and what happened:
When an OpenStackCluster CR is automatically converted from v1alpha7 to v1beta1, the field DisableAPIServerFloatingIP is converted using Convert_bool_To_optional_Bool. This function omits fields that are set to false or nil, leading to their removal from the resulting CR.

cluster-api-provider-openstack/api/v1alpha7/zz_generated.conversion.go

Line 983 in 685b5ee

if err := optional.Convert_bool_To_optional_Bool(&in.DisableAPIServerFloatingIP, &out.DisableAPIServerFloatingIP, s); err != nil {

cluster-api-provider-openstack/pkg/utils/optional/conversion.go

Lines 105 to 112 in 685b5ee

	func Convert_bool_To_optional_Bool(in *bool, out *Bool, _ conversion.Scope) error {
	if !*in {
	*out = nil
	} else {
	*out = in
	}
	return nil
	}

If spec.disableAPIServerFloatingIP field was explicitly set as false in v1alpha7, it gets removed during the upgrade to v1beta1.
Since the OpenStackCluster validation webhook does not allow changes to this field after creation, it cannot be set back to false once omitted.
This affects 3rd party controllers/operators managing CAPO CRs, as they fail when attempting to ensure the missing field.

Other optional boolean fields converted in a similar manner are also likely impacted.

What did you expect to happen:
Boolean fields that explicitly have a value (even false) should not be omitted during conversion.

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Environment:

• Cluster API Provider OpenStack version (Or git rev-parse HEAD if manually built): 0.11.2
• Cluster-API version: 0.8.4
• OpenStack version: All maintained versions
• Minikube/KIND version:
• Kubernetes version (use kubectl version): 1.31
• OS (e.g. from /etc/os-release): Ubuntu Jammy

[mnaser]

I wonder if a big part of this is probably for the fact these are "negative" boolean fields. For example, if we had a field called enableAPIServerFloatingIP and this was used, it would be just fine, cause false and no value would both result in it being disabled (implicit false), but since this is a "negative bool", this is problematic.

We'd need to audit any negative bools in thsi case.

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[okozachenko1203]

/remove-lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle rotten
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten