🌱 E2E: Use secret instead of host path for CCM config #2744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
do-not-merge/hold
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
lentzi90
force-pushed
the
lentzi90/e2e-cloud-conf-secret
branch
3 times, most recently
from
393cc77 to
726ebf5
Compare
Contributor
Author
|
Finally figured out the issue with the CCM... Now some cleanup |
Signed-off-by: Lennart Jern <[email protected]>
lentzi90
force-pushed
the
lentzi90/e2e-cloud-conf-secret
branch
from
726ebf5 to
9447f72
Compare
Contributor
Author
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lentzi90 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
smoshiur1237
reviewed
Oct 7, 2025
Contributor
smoshiur1237
left a comment
smoshiur1237
left a comment
There was a problem hiding this comment.
Thanks for the improvement.
/lgtm
k8s-ci-robot
added
the
lgtm
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This aligns the CCM manifests with upstream.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs:
/hold