-
Notifications
You must be signed in to change notification settings - Fork 282
🌱 E2E: Use kind cluster for clusterctl upgrade tests #2792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 E2E: Use kind cluster for clusterctl upgrade tests #2792
Conversation
|
/test pull-cluster-api-provider-openstack-e2e-full-test |
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This enables the UseKindForManagementCluster flag for all clusterctl upgrade tests, which makes them use a kind cluster as the secondary management cluster instead of creating an OpenStack workload cluster. This significantly reduces the resource requirements for these tests by using lightweight kind containers instead of full VMs, and it also speeds up the test execution. Signed-off-by: Lennart Jern <[email protected]>
61c9385 to
e7c1b8d
Compare
|
/test pull-cluster-api-provider-openstack-e2e-full-test |
|
Looks like it works, and saves a few minutes for the test also! |
|
There is a bit of cleanup we could do after this also, but let's take it separately in case we want to revert for some reason.
These are used to upload the CAPO image that is being tested into the management cluster. All other tests use kind clusters where the image is loaded directly, but the clusterctl upgrade was using a full CAPO cluster so we used this to get the image into it. |
|
Unknown CLA label state. Rechecking for CLA labels. Send feedback to sig-contributor-experience at kubernetes/community. /check-cla |
1 similar comment
|
Unknown CLA label state. Rechecking for CLA labels. Send feedback to sig-contributor-experience at kubernetes/community. /check-cla |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lentzi90 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
smoshiur1237
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
What this PR does / why we need it:
This enables the UseKindForManagementCluster flag for all clusterctl upgrade tests, which makes them use a kind cluster as the secondary management cluster instead of creating an OpenStack workload cluster.
This significantly reduces the resource requirements for these tests by using lightweight kind containers instead of full VMs, and it also speeds up the test execution.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #2098
Special notes for your reviewer:
TODOs:
/hold