🌱 E2E: Add quick-start test using ClusterClass #2793
Conversation
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
k8s-ci-robot
added
the
size/L
lentzi90
changed the title
|
Unknown CLA label state. Rechecking for CLA labels. Send feedback to sig-contributor-experience at kubernetes/community. /check-cla |
k8s-ci-robot
added
the
cncf-cla: yes
lentzi90
force-pushed
the
lentzi90/topology-e2e
branch
2 times, most recently
from
6bacc28 to
da1f4dc
Compare
lentzi90
changed the title
| cloudName: ${OPENSTACK_CLOUD:=capo-e2e} | ||
| name: ${CLOUD_CONFIG_SECRET:=dev-test-cloud-config} | ||
| - name: imageName | ||
| value: ${IMAGE_NAME:=flatcar_production} |
There was a problem hiding this comment.
default to ubuntu like most tests?
There was a problem hiding this comment.
Yeah I could do that. I noticed a few issues with the ClusterClass that I need to fix to get the tests passing also. Will add ORC image references at least
There was a problem hiding this comment.
Decided to go with the flatcar image for now since that is one that users can also use. We cannot encourage them to use the ubuntu images we have in CI since that would add cost to the project.
lentzi90
force-pushed
the
lentzi90/topology-e2e
branch
3 times, most recently
from
c70f787 to
ce60a04
Compare
This commit also fixes a few remaining v1beta1 references in the ClusterClass and adds support for setting images through imageRef. Signed-off-by: Lennart Jern <[email protected]>
lentzi90
force-pushed
the
lentzi90/topology-e2e
branch
from
ce60a04 to
deaa56e
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lentzi90 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
lgtm
|
/test pull-cluster-api-provider-openstack-e2e-test |
5 participants
What this PR does / why we need it:
Add a test using our ClusterClass.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #2105
Special notes for your reviewer:
TODOs: