Skip to content

✨ Shutdown VMs before Deletion #2835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

✨ Shutdown VMs before Deletion #2835

wants to merge 1 commit into from
+67 −0

Conversation

@shaardie
Copy link

@shaardie shaardie commented Nov 14, 2025

Tries to shutdown the OpenStack VM before deleting it. This way even Pods form Daemonsets are shut down more gracefully and services like license daemons on the VMs can be properly shutdown.

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1973

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • if necessary:
    • includes documentation
    • adds unit tests

/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 14, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 14, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign vincepri for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@netlify
Copy link

netlify bot commented Nov 14, 2025 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit 47154ea
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-cluster-api-openstack/deploys/691ed07141ecd2000816910a
😎 Deploy Preview https://deploy-preview-2835--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 14, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 14, 2025

Hi @shaardie. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

lentzi90
lentzi90 reviewed Nov 19, 2025
View reviewed changes
Copy link
Contributor

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
Thinking about unnecessary API calls, should we skip trying to shut it down all together if the timeout is 0?

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 19, 2025
@lentzi90
Copy link
Contributor

lentzi90 commented Nov 19, 2025

/retitle ✨ Shutdown VMs before Deletion

@k8s-ci-robot k8s-ci-robot changed the title Shutdown VMs before Deletion ✨ Shutdown VMs before Deletion Nov 19, 2025
@shaardie
Copy link
Author

shaardie commented Nov 20, 2025

/ok-to-test Thinking about unnecessary API calls, should we skip trying to shut it down all together if the timeout is 0?

Which timeout do you mean exactly? timeoutInstanceDelete seems to be hardcoded to 5min.

@shaardie
Shutdown VMs before Deletion
47154ea 
Tries to shutdown the OpenStack VM before deleting it. This way even
Pods form Daemonsets are shut down more gracefully and services like
license daemons on the VMs can be properly shutdown.

Related to kubernetes-sigs#1973
@shaardie shaardie force-pushed the shutdown-before-deletion branch from 5e56463 to 47154ea Compare November 20, 2025 08:25
@lentzi90
Copy link
Contributor

lentzi90 commented Nov 20, 2025

Oh right, I got the 0 from the issue description. But the question is still relevant. I think users should be able to opt out of this, especially since this adds more API calls.

@shaardie
Copy link
Author

shaardie commented Nov 20, 2025

Oh right, I got the 0 from the issue description. But the question is still relevant. I think users should be able to opt out of this, especially since this adds more API calls.

So you suggest a new configuration option via CRD?

@lentzi90
Copy link
Contributor

lentzi90 commented Nov 20, 2025

Hmm let me gather some second opinions. I want to have more than a gut feeling before we start modifying the CRDs 😄

@mnaser
Copy link
Contributor

mnaser commented Nov 21, 2025

I'm not sure how I feel about failing if the system doesn't shut down, I feel like it would be better if the it tries to shut it down for 5 minutes, and if it doesn't shut down, it moves on to termination.

Anyways, OpenStack will flip from a graceful to hard shutdown after 60s by default:

https://docs.openstack.org/nova/rocky/configuration/config.html#DEFAULT.graceful_shutdown_timeout

So the 5 minute timeout seems overkill as well, unless something is seriously wrong (or the cloud has that config changed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lentzi90 lentzi90 lentzi90 left review comments

@EmilienM EmilienM Awaiting requested review from EmilienM

@smoshiur1237 smoshiur1237 Awaiting requested review from smoshiur1237

Assignees

No one assigned

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

CAPO Roadmap
Status: Inbox

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Option to Shutdown VM before deleting it

4 participants

@shaardie @k8s-ci-robot @lentzi90 @mnaser