Skip to content

Commit 62e2b32

Browse files
authored
Merge pull request #3365 from chrischdi/pr-fix-v1-33-cloud-provider-flag-removal
🌱 templates: remove cloud-provider flag for kube-apiserver due to removal in v1.33
2 parents d7e756a + 772e0b8 commit 62e2b32

8 files changed

+13
-42
lines changed

packaging/flavorgen/flavors/generators.go

Lines changed: 13 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -451,10 +451,11 @@ func defaultKubeadmInitSpec(files []bootstrapv1.File) bootstrapv1.KubeadmConfigS
451451
NodeRegistration: defaultNodeRegistrationOptions(),
452452
},
453453
ClusterConfiguration: &bootstrapv1.ClusterConfiguration{
454-
APIServer: bootstrapv1.APIServer{
455-
ControlPlaneComponent: defaultControlPlaneComponent(),
454+
ControllerManager: bootstrapv1.ControlPlaneComponent{
455+
ExtraArgs: map[string]string{
456+
"cloud-provider": "external",
457+
},
456458
},
457-
ControllerManager: defaultControlPlaneComponent(),
458459
},
459460
Users: defaultUsers(),
460461
PreKubeadmCommands: defaultPreKubeadmCommands(),
@@ -480,10 +481,11 @@ func ignitionKubeadmInitSpec(files []bootstrapv1.File) bootstrapv1.KubeadmConfig
480481
NodeRegistration: nro,
481482
},
482483
ClusterConfiguration: &bootstrapv1.ClusterConfiguration{
483-
APIServer: bootstrapv1.APIServer{
484-
ControlPlaneComponent: defaultControlPlaneComponent(),
484+
ControllerManager: bootstrapv1.ControlPlaneComponent{
485+
ExtraArgs: map[string]string{
486+
"cloud-provider": "external",
487+
},
485488
},
486-
ControllerManager: defaultControlPlaneComponent(),
487489
},
488490
Users: flatcarUsers(),
489491
PreKubeadmCommands: flatcarPreKubeadmCommands(),
@@ -555,9 +557,11 @@ func newIgnitionKubeadmConfigTemplate() bootstrapv1.KubeadmConfigTemplate {
555557

556558
func defaultNodeRegistrationOptions() bootstrapv1.NodeRegistrationOptions {
557559
return bootstrapv1.NodeRegistrationOptions{
558-
Name: "{{ local_hostname }}",
559-
CRISocket: "/var/run/containerd/containerd.sock",
560-
KubeletExtraArgs: defaultExtraArgs(),
560+
Name: "{{ local_hostname }}",
561+
CRISocket: "/var/run/containerd/containerd.sock",
562+
KubeletExtraArgs: map[string]string{
563+
"cloud-provider": "external",
564+
},
561565
}
562566
}
563567

@@ -585,22 +589,10 @@ func flatcarUsers() []bootstrapv1.User {
585589
}
586590
}
587591

588-
func defaultControlPlaneComponent() bootstrapv1.ControlPlaneComponent {
589-
return bootstrapv1.ControlPlaneComponent{
590-
ExtraArgs: defaultExtraArgs(),
591-
}
592-
}
593-
594592
func defaultCustomVMXKeys() map[string]string {
595593
return map[string]string{}
596594
}
597595

598-
func defaultExtraArgs() map[string]string {
599-
return map[string]string{
600-
"cloud-provider": "external",
601-
}
602-
}
603-
604596
func defaultPreKubeadmCommands() []string {
605597
return []string{
606598
"hostnamectl set-hostname \"{{ ds.meta_data.hostname }}\"",

templates/cluster-template-external-loadbalancer.yaml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -96,9 +96,6 @@ metadata:
9696
spec:
9797
kubeadmConfigSpec:
9898
clusterConfiguration:
99-
apiServer:
100-
extraArgs:
101-
cloud-provider: external
10299
controllerManager:
103100
extraArgs:
104101
cloud-provider: external

templates/cluster-template-ignition.yaml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -69,9 +69,6 @@ metadata:
6969
spec:
7070
kubeadmConfigSpec:
7171
clusterConfiguration:
72-
apiServer:
73-
extraArgs:
74-
cloud-provider: external
7572
controllerManager:
7673
extraArgs:
7774
cloud-provider: external

templates/cluster-template-node-ipam.yaml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -106,9 +106,6 @@ metadata:
106106
spec:
107107
kubeadmConfigSpec:
108108
clusterConfiguration:
109-
apiServer:
110-
extraArgs:
111-
cloud-provider: external
112109
controllerManager:
113110
extraArgs:
114111
cloud-provider: external

templates/cluster-template-supervisor.yaml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -63,9 +63,6 @@ metadata:
6363
spec:
6464
kubeadmConfigSpec:
6565
clusterConfiguration:
66-
apiServer:
67-
extraArgs:
68-
cloud-provider: external
6966
controllerManager:
7067
extraArgs:
7168
cloud-provider: external

templates/cluster-template.yaml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -96,9 +96,6 @@ metadata:
9696
spec:
9797
kubeadmConfigSpec:
9898
clusterConfiguration:
99-
apiServer:
100-
extraArgs:
101-
cloud-provider: external
10299
controllerManager:
103100
extraArgs:
104101
cloud-provider: external

templates/clusterclass-template-supervisor.yaml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -264,9 +264,6 @@ spec:
264264
spec:
265265
kubeadmConfigSpec:
266266
clusterConfiguration:
267-
apiServer:
268-
extraArgs:
269-
cloud-provider: external
270267
controllerManager:
271268
extraArgs:
272269
cloud-provider: external

templates/clusterclass-template.yaml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -324,9 +324,6 @@ spec:
324324
spec:
325325
kubeadmConfigSpec:
326326
clusterConfiguration:
327-
apiServer:
328-
extraArgs:
329-
cloud-provider: external
330327
controllerManager:
331328
extraArgs:
332329
cloud-provider: external

0 commit comments

Comments
 (0)