Skip to content

Commit d55ab7f

Browse files
authored
Merge pull request #2103 from sbueringer/pr-deprecate-auto-configure
🌱 Deprecate AutoConfigure functionality
2 parents 64f7ddd + eb47894 commit d55ab7f

File tree

3 files changed

+13
-4
lines changed

3 files changed

+13
-4
lines changed

.golangci.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,11 @@ issue:
5252
max-per-linter: 0
5353
issues:
5454
exclude-rules:
55+
# Specific exclude rules for deprecated fields that are still part of the codebase. These
56+
# should be removed as the referenced deprecated item is removed from the project.
57+
- linters:
58+
- staticcheck
59+
text: "SA1019: failureDomain.AutoConfigure is deprecated"
5560
- path: "test/e2e/*"
5661
linters:
5762
- gosec

apis/v1beta1/vspherefailuredomain_types.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,8 @@ type FailureDomain struct {
5454
TagCategory string `json:"tagCategory"`
5555

5656
// AutoConfigure tags the Type which is specified in the Topology
57+
//
58+
// Deprecated: This field is going to be removed in a future release.
5759
AutoConfigure *bool `json:"autoConfigure,omitempty"`
5860
}
5961

config/default/crd/bases/infrastructure.cluster.x-k8s.io_vspherefailuredomains.yaml

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -283,8 +283,9 @@ spec:
283283
description: Region defines the name and type of a region
284284
properties:
285285
autoConfigure:
286-
description: AutoConfigure tags the Type which is specified in
287-
the Topology
286+
description: "AutoConfigure tags the Type which is specified in
287+
the Topology \n Deprecated: This field is going to be removed
288+
in a future release."
288289
type: boolean
289290
name:
290291
description: Name is the name of the tag that represents this
@@ -347,8 +348,9 @@ spec:
347348
description: Zone defines the name and type of a zone
348349
properties:
349350
autoConfigure:
350-
description: AutoConfigure tags the Type which is specified in
351-
the Topology
351+
description: "AutoConfigure tags the Type which is specified in
352+
the Topology \n Deprecated: This field is going to be removed
353+
in a future release."
352354
type: boolean
353355
name:
354356
description: Name is the name of the tag that represents this

0 commit comments

Comments
 (0)