Set InternalIP machine status.addresses

[andrewsykim]

/kind feature

Describe the solution you'd like
Almost always a VM will have an address internal to the datacenter. In the case where we don't know if an address is external or internal to the datacenter, we should assume it is internal and set the type as InternalIP. Today we always set it as an ExternalIP

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Environment:

• Cluster-api-provider-vsphere version:
• Kubernetes version: (use kubectl version):
• OS (e.g. from /etc/os-release):

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[andrewsykim]

/remove-lifecycle stale

This is still pretty important from my perspective, in general we shouldn't label private addresses spaces as ExternalIP. It's also not consistent with how we address node addresses.

[yastij]

@andrewsykim - Agreed. As this is a breaking changing my thinking was to include this in the set of breaking changes of v1a4