Skip to content

Commit 182df0b

Browse files
committed
docs: update sections about checking image scans
Signed-off-by: cprivitere <[email protected]>
1 parent 9fbc50a commit 182df0b

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

docs/release/role-handbooks/ci-signal/README.md

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,8 +68,10 @@ The goal of this task is to keep our tests running in CI stable.
6868
1. Create an issue using an appropriate template (failing-test) in the Cluster API repository to surface the CI failure.
6969
2. Identify if the issue is a known issue, new issue or a regression.
7070
3. Mark the issue as `release-blocking` if applicable.
71-
6. Triage periodic GitHub actions failures, with special attention to image scan results;
72-
Eventually open issues as described above.
71+
6. Triage periodic GitHub actions failures and image scan results.
72+
* Ensure that the release branch is stable and all tests are passing on [testgrid](https://testgrid.k8s.io/sig-cluster-lifecycle-cluster-api).
73+
* Verify the [Weekly security scan](https://github.com/kubernetes-sigs/cluster-api/actions/workflows/weekly-security-scan.yaml) results are clean.
74+
* Eventually open issues as described above.
7375
7. Run periodic deep-dive sessions with the CI team to investigate failing and flaking tests. Example session recording: https://www.youtube.com/watch?v=YApWftmiDTg
7476

7577
**Note**: Maintaining the health of the project is a community effort. CI team should use all of the tools available to them to attempt to keep the CI signal clean, however the [#cluster-api](https://kubernetes.slack.com/archives/C8TSNPY4T) Slack channel should be used to increase visibility of release blocking interruptions to the CI signal and seek help from community. This should be *additive* to the steps described above. When in doubt, err on the side of overcommunication to promote awareness and drive disruptions to resolution.

docs/release/role-handbooks/release-lead/README.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,9 @@ to a newer Go minor version according to our [backport policy](./../../../../CON
172172
### [Repeatedly] Cut a release
173173

174174
1. Ensure CI is stable before cutting the release (e.g. by checking with the CI manager)
175-
Note: special attention should be given to image scan results, so we can avoid cutting a release with CVE or document known CVEs in release notes.
175+
* Ensure there are no [open PRs or issues that are blocking the release](https://github.com/kubernetes-sigs/cluster-api/issues?q=label%3Akind%2Frelease-blocking%20state%3Aopen).
176+
* Ensure that the release branch is stable and all tests are passing on [testgrid](https://testgrid.k8s.io/sig-cluster-lifecycle-cluster-api).
177+
* Verify the [Weekly security scan](https://github.com/kubernetes-sigs/cluster-api/actions/workflows/weekly-security-scan.yaml) results are clean.
176178
2. Ask the [Communications/Docs/Release Notes Manager](../communications/README.md) to [create a PR with the release notes](../communications/README.md#create-pr-for-release-notes) for the new desired tag and review the PR. Once the PR merges, it will trigger a [GitHub Action](https://github.com/kubernetes-sigs/cluster-api/actions/workflows/release.yaml) to create a release branch, push release tags, and create a draft release. This will also trigger a [ProwJob](https://prow.k8s.io/?repo=kubernetes-sigs%2Fcluster-api&job=post-cluster-api-push-images) to publish images to the staging repository.
177179
3. Promote images from the staging repository to the production registry (`registry.k8s.io/cluster-api`):
178180
1. Wait until images for the tag have been built and pushed to the [staging repository](https://console.cloud.google.com/gcr/images/k8s-staging-cluster-api) by the [post push images job](https://prow.k8s.io/?repo=kubernetes-sigs%2Fcluster-api&job=post-cluster-api-push-images).

0 commit comments

Comments
 (0)