Skip to content

Commit 192517b

Browse files
authored
Merge pull request #7838 from knabben/remove-list-images
⚠️ Removing deprecated --list-images flag on init command
2 parents 7bf3ea6 + 913714d commit 192517b

File tree

2 files changed

+1
-18
lines changed

2 files changed

+1
-18
lines changed

cmd/clusterctl/cmd/init.go

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ limitations under the License.
1717
package cmd
1818

1919
import (
20-
"fmt"
2120
"time"
2221

2322
"github.com/spf13/cobra"
@@ -35,7 +34,6 @@ type initOptions struct {
3534
ipamProviders []string
3635
runtimeExtensionProviders []string
3736
targetNamespace string
38-
listImages bool
3937
validate bool
4038
waitProviders bool
4139
waitProviderTimeout int
@@ -114,10 +112,6 @@ func init() {
114112
initCmd.Flags().BoolVar(&initOpts.validate, "validate", true,
115113
"If true, clusterctl will validate that the deployments will succeed on the management cluster.")
116114

117-
initCmd.Flags().BoolVar(&initOpts.listImages, "list-images", false,
118-
"Lists the container images required for initializing the management cluster (without actually installing the providers)")
119-
_ = initCmd.Flags().MarkDeprecated("list-images", "use 'clusterctl init list-images' instead.")
120-
121115
initCmd.AddCommand(initListImagesCmd)
122116
RootCmd.AddCommand(initCmd)
123117
}
@@ -143,18 +137,6 @@ func runInit() error {
143137
IgnoreValidationErrors: !initOpts.validate,
144138
}
145139

146-
if initOpts.listImages {
147-
images, err := c.InitImages(options)
148-
if err != nil {
149-
return err
150-
}
151-
152-
for _, i := range images {
153-
fmt.Println(i)
154-
}
155-
return nil
156-
}
157-
158140
if _, err := c.Init(options); err != nil {
159141
return err
160142
}

docs/book/src/developer/providers/v1.3-to-v1.4.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ maintainers of providers and consumers of our Go API.
2323
- `clusterctl backup` has been removed.
2424
- `MachineHealthCheckSuccededCondition` condition type has been removed.
2525
- `CloneTemplate` and `CloneTemplateInput` has been removed.
26+
- The option `--list-images` from `init` subcommand has been removed.
2627

2728
### API Changes
2829

0 commit comments

Comments
 (0)