Skip to content

Commit 1eedede

Browse files
authored
Merge pull request #7779 from sbueringer/pr-fix-md-replicas-comment
🌱 Cluster topology: fix comment about MD replicas defaulting
2 parents 6095481 + 0c80b9d commit 1eedede

File tree

5 files changed

+6
-6
lines changed

5 files changed

+6
-6
lines changed

api/v1beta1/cluster_types.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ type MachineDeploymentTopology struct {
171171
FailureDomain *string `json:"failureDomain,omitempty"`
172172

173173
// Replicas is the number of worker nodes belonging to this set.
174-
// If the value is nil, the MachineDeployment is created without the number of Replicas (defaulting to zero)
174+
// If the value is nil, the MachineDeployment is created without the number of Replicas (defaulting to 1)
175175
// and it's assumed that an external entity (like cluster autoscaler) is responsible for the management
176176
// of this value.
177177
// +optional

api/v1beta1/zz_generated.openapi.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

config/crd/bases/cluster.x-k8s.io_clusters.yaml

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

docs/proposals/20210526-cluster-class-and-managed-topologies.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -607,7 +607,7 @@ Note: Builtin variables are defined in [Builtin variables](#builtin-variables) b
607607
Name string `json:"name"`
608608
609609
// The number of worker nodes belonging to this set.
610-
// If the value is nil, the MachineDeployment is created without the number of Replicas (defaulting to zero)
610+
// If the value is nil, the MachineDeployment is created without the number of Replicas (defaulting to 1)
611611
// and it's assumed that an external entity (like cluster autoscaler) is responsible for the management
612612
// of this value.
613613
// +optional

docs/proposals/images/runtime-hooks/runtime-hooks-openapi.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -525,7 +525,7 @@ components:
525525
replicas:
526526
description: Replicas is the number of worker nodes belonging to this set.
527527
If the value is nil, the MachineDeployment is created without the number
528-
of Replicas (defaulting to zero) and it's assumed that an external entity
528+
of Replicas (defaulting to 1) and it's assumed that an external entity
529529
(like cluster autoscaler) is responsible for the management of this value.
530530
format: int32
531531
type: integer

0 commit comments

Comments
 (0)