Merge pull request #11566 from chrischdi/pr-cleanup-todo-chrischdi

k8s-ci-robot · web-flow · commit 1f7b3887b8d2 · 2024-12-13T11:18:25.000+01:00
🌱 machine: remove solved todo comment
diff --git a/internal/controllers/machine/machine_controller.go b/internal/controllers/machine/machine_controller.go
@@ -643,7 +643,6 @@ const (
 )
 
 func (r *Reconciler) isNodeDrainAllowed(m *clusterv1.Machine) bool {
-	// TODO(chrischdi) check why this does not work
 	if util.IsControlPlaneMachine(m) && util.HasOwner(m.GetOwnerReferences(), KubeadmControlPlaneAPIVersion, []string{"KubeadmControlPlane"}) {
 		if _, exists := m.Annotations[KubeadmControlPlanePreTerminateHookCleanupAnnotation]; !exists {
 			return false

Original file line number	Diff line number	Diff line change
`@@ -643,7 +643,6 @@ const (`
`643`	`643`	`)`
`644`	`644`
`645`	`645`	`func (r Reconciler) isNodeDrainAllowed(m clusterv1.Machine) bool {`
`646`		`- // TODO(chrischdi) check why this does not work`
`647`	`646`	`if util.IsControlPlaneMachine(m) && util.HasOwner(m.GetOwnerReferences(), KubeadmControlPlaneAPIVersion, []string{"KubeadmControlPlane"}) {`
`648`	`647`	`if _, exists := m.Annotations[KubeadmControlPlanePreTerminateHookCleanupAnnotation]; !exists {`
`649`	`648`	`return false`