Skip draining failed DaemonSet pods to prevent recreation loops

In scenarios where nodes experience DiskPressure, DaemonSet pods may be
evicted and enter Failed state. When deleting Machines, cluster-api attempts
to delete these failed pods, but this triggers DaemonSet to create new pods
which can then be evicted again due to persistent DiskPressure, creating an
infinite loop.

Signed-off-by: liuxu <[email protected]>

Author: liuxu623

internal/controllers/machine/drain/filters.go

@@ -212,10 +212,6 @@ func (d *Helper) daemonSetFilter(ctx context.Context, pod *corev1.Pod) PodDelete
 	if controllerRef == nil || controllerRef.Kind != appsv1.SchemeGroupVersion.WithKind("DaemonSet").Kind {
 		return MakePodDeleteStatusOkay()
 	}
-	// Any finished pod can be removed.
-	if pod.Status.Phase == corev1.PodSucceeded || pod.Status.Phase == corev1.PodFailed {
-		return MakePodDeleteStatusOkay()
-	}
 
 	if err := d.RemoteClient.Get(ctx, client.ObjectKey{Namespace: pod.Namespace, Name: controllerRef.Name}, &appsv1.DaemonSet{}); err != nil {
 		// remove orphaned pods with a warning