Update ClusterResourceSetBinding owner references

dlipovetsky · dlipovetsky · commit 2f0540f8700d · 2022-09-28T13:00:15.000-07:00
The ClusterResourceSet owner references were being updated due to a
typo. This update was ineffectual, because the ClusterResourceSet object
is not patched after the references are updated.

However, due to a separate bug in RemoveOwnerRef, the
ClusterResourceSetBinding owner references _were_ being updated.
diff --git a/exp/addons/api/v1beta1/clusterresourcesetbinding_types.go b/exp/addons/api/v1beta1/clusterresourcesetbinding_types.go
@@ -102,7 +102,7 @@ func (c *ClusterResourceSetBinding) DeleteBinding(clusterResourceSet *ClusterRes
 			break
 		}
 	}
-	clusterResourceSet.OwnerReferences = util.RemoveOwnerRef(c.OwnerReferences, metav1.OwnerReference{
+	c.OwnerReferences = util.RemoveOwnerRef(c.OwnerReferences, metav1.OwnerReference{
 		APIVersion: clusterResourceSet.APIVersion,
 		Kind:       clusterResourceSet.Kind,
 		Name:       clusterResourceSet.Name,

Original file line number	Diff line number	Diff line change
`@@ -102,7 +102,7 @@ func (c ClusterResourceSetBinding) DeleteBinding(clusterResourceSet ClusterRes`
`102`	`102`	`break`
`103`	`103`	`}`
`104`	`104`	`}`
`105`		`- clusterResourceSet.OwnerReferences = util.RemoveOwnerRef(c.OwnerReferences, metav1.OwnerReference{`
	`105`	`+ c.OwnerReferences = util.RemoveOwnerRef(c.OwnerReferences, metav1.OwnerReference{`
`106`	`106`	`APIVersion: clusterResourceSet.APIVersion,`
`107`	`107`	`Kind: clusterResourceSet.Kind,`
`108`	`108`	`Name: clusterResourceSet.Name,`