Skip to content

Commit 4d76266

Browse files
authored
Merge pull request #8956 from enxebre/doc-MinReadySeconds
🌱 Adjust MinReadySeconds docs to reality
2 parents cb5ce4c + 3e7e4f6 commit 4d76266

File tree

5 files changed

+13
-13
lines changed

5 files changed

+13
-13
lines changed

api/v1beta1/machinedeployment_types.go

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -121,10 +121,8 @@ type MachineDeploymentSpec struct {
121121
// +optional
122122
Strategy *MachineDeploymentStrategy `json:"strategy,omitempty"`
123123

124-
// Minimum number of seconds for which a newly created machine should
125-
// be ready.
126-
// Defaults to 0 (machine will be considered available as soon as it
127-
// is ready)
124+
// MinReadySeconds is the minimum number of seconds for which a Node for a newly created machine should be ready before considering the replica available.
125+
// Defaults to 0 (machine will be considered available as soon as the Node is ready)
128126
// +optional
129127
MinReadySeconds *int32 `json:"minReadySeconds,omitempty"`
130128

api/v1beta1/machineset_types.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,8 @@ type MachineSetSpec struct {
4646
// +kubebuilder:default=1
4747
Replicas *int32 `json:"replicas,omitempty"`
4848

49-
// MinReadySeconds is the minimum number of seconds for which a newly created machine should be ready.
50-
// Defaults to 0 (machine will be considered available as soon as it is ready)
49+
// MinReadySeconds is the minimum number of seconds for which a Node for a newly created machine should be ready before considering the replica available.
50+
// Defaults to 0 (machine will be considered available as soon as the Node is ready)
5151
// +optional
5252
MinReadySeconds int32 `json:"minReadySeconds,omitempty"`
5353

api/v1beta1/zz_generated.openapi.go

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

config/crd/bases/cluster.x-k8s.io_machinedeployments.yaml

Lines changed: 4 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

config/crd/bases/cluster.x-k8s.io_machinesets.yaml

Lines changed: 3 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)