Skip to content

Commit 5322fce

Browse files
authored
Merge pull request #8439 from killianmuldoon/fix-migration-links
📖 Fix broken links in migrations guides
2 parents 717c7e3 + a47e96f commit 5322fce

File tree

4 files changed

+8
-8
lines changed

4 files changed

+8
-8
lines changed

docs/book/src/developer/providers/migrations/v0.4-to-v1.0.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ Users relying on custom upgrades procedures should ensure a migration to v1alpha
6969
Otherwise, your controller might end up with multiple running instances that each acquired leadership through different resource locks during upgrades and thus act on the same resources concurrently.
7070

7171

72-
[cluster-contract]: ./cluster-infrastructure.md
73-
[machine-contract]: ./machine-infrastructure.md
74-
[metadata-propagation]: ../../developer/architecture/controllers/metadata-propagation.md
72+
[cluster-contract]: ./../cluster-infrastructure.md
73+
[machine-contract]: ./../machine-infrastructure.md
74+
[metadata-propagation]: ../../../developer/architecture/controllers/metadata-propagation.md
7575
[capv-ipam]: https://github.com/kubernetes-sigs/cluster-api-provider-vsphere/pull/1210

docs/book/src/developer/providers/migrations/v1.0-to-v1.1.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ are kept in sync with the versions used by `sigs.k8s.io/controller-runtime`.
5656

5757
* ClusterClass:
5858
* `clusterctl` is now able to handle cluster templates with ClusterClasses ([PR](https://github.com/kubernetes-sigs/cluster-api/pull/5351)).
59-
Please check out the corresponding documentation in [clusterctl provider contract](../../clusterctl/provider-contract.md#clusterclass-definitions)
59+
Please check out the corresponding documentation in [clusterctl provider contract](../../../clusterctl/provider-contract.md#clusterclass-definitions)
6060
If you have any further questions about writing ClusterClasses, please let us know.
6161
* e2e tests:
6262
* `QuickStartSpec` is now able to test clusters using ClusterClass. Please see this [PR](https://github.com/kubernetes-sigs/cluster-api/pull/5423) for an example on how to use it.

docs/book/src/developer/providers/migrations/v1.2-to-v1.3.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ in Cluster API are kept in sync with the versions used by `sigs.k8s.io/controlle
4141
- A new timeout `nodeVolumeDetachTimeout` has been introduced that defines how long the controller will spend on waiting for all volumes to be detached.
4242
The default value is 0, meaning that the volume can be detached without any time limitations.
4343
- A new annotation `machine.cluster.x-k8s.io/exclude-wait-for-node-volume-detach` has been introduced that allows explicitly skip the waiting for node volume detaching.
44-
- A new annotation `"cluster.x-k8s.io/replicas-managed-by"` has been introduced to indicate that a MachinePool's replica enforcement is delegated to an external autoscaler (not managed by Cluster API). For more information see the documentation [here](../architecture/controllers/machine-pool.md#externally-managed-autoscaler).
44+
- A new annotation `"cluster.x-k8s.io/replicas-managed-by"` has been introduced to indicate that a MachinePool's replica enforcement is delegated to an external autoscaler (not managed by Cluster API). For more information see the documentation [here](../../architecture/controllers/machine-pool.md#externally-managed-autoscaler).
4545
- The `Path` func in the `sigs.k8s.io/cluster-api/cmd/clusterctl/client/repository.Overrider` interface has been adjusted to also return an error.
4646

4747
### Other
@@ -55,8 +55,8 @@ The default value is 0, meaning that the volume can be detached without any time
5555
* the default test timeout has been [changed to 1h](https://onsi.github.io/ginkgo/MIGRATING_TO_V2#timeout-behavior)
5656
* the `--junit-report` argument [replaces JUnit custom reporter](https://onsi.github.io/ginkgo/MIGRATING_TO_V2#improved-reporting-infrastructure) code
5757
* see the ["Update tests to Ginkgo v2" PR](https://github.com/kubernetes-sigs/cluster-api/pull/6906) for a reference example
58-
- Cluster API introduced new [logging guidelines](../../developer/logging.md). All reconcilers in the core repository were updated
59-
to [log the entire object hierarchy](../../developer/logging.md#keyvalue-pairs). It would be great if providers would be adjusted
58+
- Cluster API introduced new [logging guidelines](../../../developer/logging.md). All reconcilers in the core repository were updated
59+
to [log the entire object hierarchy](../../../developer/logging.md#keyvalue-pairs). It would be great if providers would be adjusted
6060
as well to make it possible to cross-reference log entries across providers (please see CAPD for an infra provider reference implementation).
6161
- The `CreateLogFile` function and `CreateLogFileInput` struct in the E2E test framework for clusterctl has been renamed to `OpenLogFile` and `OpenLogFileInput` because the function will now append to the logfile instead of truncating the content.
6262
- The `Move` function in E2E test framework for clusterctl has been modified to:

docs/book/src/developer/providers/migrations/v1.3-to-v1.4.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ maintainers of providers and consumers of our Go API.
2323
- `v1alpha3` will be removed in v1.5
2424
- `v1alpha4` will be removed in v1.6
2525

26-
For more information please see [the note in the contributors guide](../../CONTRIBUTING.md#removal-of-v1alpha3--v1alpha4-apiversions).
26+
For more information please see [the note in the contributors guide](../../../CONTRIBUTING.md#removal-of-v1alpha3--v1alpha4-apiversions).
2727

2828
### Removals
2929

0 commit comments

Comments
 (0)