Skip to content

Commit 61e7dcc

Browse files
authored
Merge pull request #6159 from sbueringer/pr-refactor-book-verification
🌱 book: refactor verification
2 parents fbc39a0 + 7cdce7c commit 61e7dcc

File tree

3 files changed

+8
-16
lines changed

3 files changed

+8
-16
lines changed

Makefile

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -316,7 +316,7 @@ APIDIFF_OLD_COMMIT ?= $(shell git rev-parse origin/main)
316316
apidiff: $(GO_APIDIFF) ## Check for API differences
317317
$(GO_APIDIFF) $(APIDIFF_OLD_COMMIT) --print-compatible
318318

319-
ALL_VERIFY_CHECKS = doctoc boilerplate shellcheck tiltfile modules gen conversions docker-provider book-links
319+
ALL_VERIFY_CHECKS = doctoc boilerplate shellcheck tiltfile modules gen conversions docker-provider
320320

321321
.PHONY: verify
322322
verify: $(addprefix verify-,$(ALL_VERIFY_CHECKS)) ## Run all verify-* targets
@@ -364,10 +364,6 @@ verify-docker-provider:
364364
@echo "Verifying CAPD"
365365
cd $(CAPD_DIR); $(MAKE) verify
366366

367-
.PHONY: verify-book-links
368-
verify-book-links: ## Verify book links
369-
$(MAKE) -C docs/book verify
370-
371367
## --------------------------------------
372368
## Binaries
373369
## --------------------------------------
@@ -435,6 +431,10 @@ docker-build-kubeadm-control-plane: ## Build the docker image for kubeadm contro
435431
e2e-framework: ## Builds the CAPI e2e framework
436432
cd $(E2E_FRAMEWORK_DIR); go build ./...
437433

434+
.PHONY: build-book
435+
build-book: ## Build the book
436+
$(MAKE) -C docs/book build
437+
438438
.PHONY: serve-book
439439
serve-book: ## Build and serve the book (with live-reload)
440440
$(MAKE) -C docs/book serve

docs/book/Makefile

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -38,18 +38,10 @@ MDBOOK := $(TOOLS_BIN_DIR)/mdbook
3838
$(MDBOOK):
3939
$(CRATE_INSTALL) --git rust-lang/mdBook --tag v0.4.11 --to $(TOOLS_BIN_DIR) --force
4040

41-
MDBOOK_LINKCHECK := $(TOOLS_BIN_DIR)/mdbook-linkcheck
42-
$(MDBOOK_LINKCHECK):
43-
$(CRATE_INSTALL) --git Michael-F-Bryan/mdbook-linkcheck --tag v0.7.0 --to $(TOOLS_BIN_DIR) --force
44-
4541
.PHONY: serve
46-
serve: $(MDBOOK) $(TABULATE) $(EMBED) $(RELEASELINK) $(MDBOOK_LINKCHECK)
42+
serve: $(MDBOOK) $(TABULATE) $(EMBED) $(RELEASELINK)
4743
$(MDBOOK) serve
4844

4945
.PHONY: build
50-
build: $(MDBOOK) $(TABULATE) $(EMBED) $(RELEASELINK) $(MDBOOK_LINKCHECK)
51-
$(MDBOOK) build
52-
53-
.PHONY: verify
54-
verify: $(MDBOOK) $(TABULATE) $(EMBED) $(RELEASELINK) $(MDBOOK_LINKCHECK)
46+
build: $(MDBOOK) $(TABULATE) $(EMBED) $(RELEASELINK)
5547
$(MDBOOK) build

scripts/ci-build.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ set -o pipefail
2121
REPO_ROOT=$(dirname "${BASH_SOURCE[0]}")/..
2222

2323
# Core Cluster API
24-
cd "${REPO_ROOT}" && make managers clusterctl e2e-framework
24+
cd "${REPO_ROOT}" && make managers clusterctl e2e-framework build-book
2525

2626
echo "*** Building Cluster API Provider Docker ***"
2727
# Docker provider

0 commit comments

Comments
 (0)