🐛 Fix MaxLength of worker topology Name fields (#12072)

* Fix MaxLength of worker topology Name fields

Due to existing webhook validation, the max length was effectively 63
characters. This updates the annotation (and CRD) to reflect this actual
max length.

* fixup! Fix MaxLength of worker topology Name fields

Adjust to 63 because maxLength is inclusive

Author: dlipovetsky

api/v1beta1/cluster_types.go

@@ -686,7 +686,7 @@ type MachineDeploymentTopology struct {
 	// the values are hashed together.
 	// +required
 	// +kubebuilder:validation:MinLength=1
-	// +kubebuilder:validation:MaxLength=256
+	// +kubebuilder:validation:MaxLength=63
 	Name string `json:"name"`
 
 	// failureDomain is the failure domain the machines will be created in.
@@ -797,7 +797,7 @@ type MachinePoolTopology struct {
 	// the values are hashed together.
 	// +required
 	// +kubebuilder:validation:MinLength=1
-	// +kubebuilder:validation:MaxLength=256
+	// +kubebuilder:validation:MaxLength=63
 	Name string `json:"name"`
 
 	// failureDomains is the list of failure domains the machine pool will be created in.

api/v1beta2/cluster_types.go

@@ -686,7 +686,7 @@ type MachineDeploymentTopology struct {
 	// the values are hashed together.
 	// +required
 	// +kubebuilder:validation:MinLength=1
-	// +kubebuilder:validation:MaxLength=256
+	// +kubebuilder:validation:MaxLength=63
 	Name string `json:"name"`
 
 	// failureDomain is the failure domain the machines will be created in.
@@ -797,7 +797,7 @@ type MachinePoolTopology struct {
 	// the values are hashed together.
 	// +required
 	// +kubebuilder:validation:MinLength=1
-	// +kubebuilder:validation:MaxLength=256
+	// +kubebuilder:validation:MaxLength=63
 	Name string `json:"name"`
 
 	// failureDomains is the list of failure domains the machine pool will be created in.