Skip to content

Commit 6b40f8f

Browse files
authored
Merge pull request #8036 from elmiko/update-sfz-proposal
📖 update autoscaling from zero proposal
2 parents 9c5671a + a8e76e8 commit 6b40f8f

File tree

1 file changed

+17
-1
lines changed

1 file changed

+17
-1
lines changed

docs/proposals/20210310-opt-in-autoscaling-from-zero.md

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ reviewers:
1313
- "@randomvariable"
1414
- "@joelspeed"
1515
creation-date: 2021-03-10
16-
last-updated: 2021-08-24
16+
last-updated: 2023-01-31
1717
status: implementable
1818
---
1919

@@ -221,9 +221,24 @@ metadata:
221221
capacity.cluster-autoscaler.kubernetes.io/gpu-type: "nvidia.com/gpu"
222222
capacity.cluster-autoscaler.kubernetes.io/memory: "500mb"
223223
capacity.cluster-autoscaler.kubernetes.io/cpu: "1"
224+
capacity.cluster-autoscaler.kubernetes.io/ephemeral-disk: "100Gi"
224225
```
225226
_Note: the annotations will be defined in the cluster autoscaler, not in cluster-api._
226227

228+
**Node Labels and Taints**
229+
230+
When a user would like to signal that the node being created from a MachineSet or
231+
MachineDeployment will have specific taints or labels on it, they can use the following
232+
annotations to specify that information.
233+
234+
```
235+
kind: <MachineSet or MachineDeployment>
236+
metadata:
237+
annotations:
238+
capacity.cluster-autoscaler.kubernetes.io/labels: "key1=value1,key2=value2"
239+
capacity.cluster-autoscaler.kubernetes.io/taints: "key1=value1:NoSchedule,key2=value2:NoExecute"
240+
```
241+
227242
### Security Model
228243

229244
This feature will require the service account associated with the cluster autoscaler to have
@@ -286,6 +301,7 @@ the cluster autoscaler and Cluster API have resolved more.
286301

287302
## Implementation History
288303

304+
- [X] 01/31/2023: Updated proposal to include annotation changes
289305
- [X] 06/10/2021: Proposed idea in an issue or [community meeting]
290306
- [X] 03/04/2020: Previous pull request for [Add cluster autoscaler scale from zero ux proposal](https://github.com/kubernetes-sigs/cluster-api/pull/2530)
291307
- [X] 10/07/2020: First round of feedback from community [initial proposal]

0 commit comments

Comments
 (0)