Skip to content

Commit 6bb0b1b

Browse files
More feedback
1 parent f283af9 commit 6bb0b1b

File tree

2 files changed

+16
-6
lines changed

2 files changed

+16
-6
lines changed

docs/proposals/20220414-lifecycle-hooks.md

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -164,6 +164,9 @@ workersUpgrades:
164164
- version: v1.33.0
165165
```
166166
167+
Note: The `controlPlaneUpgrades` and the `workersUpgrades` fields contains the intermediate steps to reach the target version,
168+
which is also included in the list.
169+
167170
#### BeforeControlPlaneUpgrade (new hook)
168171

169172
This hook is called before a new version is propagated to the control plane object. Runtime Extension implementers
@@ -201,7 +204,8 @@ workersUpgrades:
201204
- version: v1.33.0
202205
```
203206

204-
Note: The upgrade plan in the request contains only missing steps to reach the target version.
207+
Note: The `controlPlaneUpgrades` and the `workersUpgrades` fields contains the intermediate steps to reach the target version,
208+
which is also included in the list.
205209

206210
##### Example Response:
207211

@@ -255,7 +259,8 @@ workersUpgrades:
255259
- version: v1.33.0
256260
```
257261

258-
Note: The upgrade plan in the request contains only missing steps to reach the target version, if any.
262+
Note: The `controlPlaneUpgrades` and the `workersUpgrades` fields contains the intermediate steps to reach the target version,
263+
which is also included in the list.
259264

260265
##### Example Response:
261266

@@ -303,7 +308,8 @@ workersUpgrades:
303308
- version: v1.33.0
304309
```
305310

306-
Note: The upgrade plan in the request contains only missing steps to reach the target version.
311+
Note: The `controlPlaneUpgrades` and the `workersUpgrades` fields contains the intermediate steps to reach the target version,
312+
which is also included in the list.
307313

308314
##### Example Response:
309315

@@ -350,7 +356,8 @@ workersUpgrades:
350356
- version: v1.33.0
351357
```
352358

353-
Note: The upgrade plan in the request contains only missing steps to reach the target version, if any.
359+
Note: The `controlPlaneUpgrades` and the `workersUpgrades` fields contains the intermediate steps to reach the target version,
360+
which is also included in the list.
354361

355362
##### Example Response:
356363

docs/proposals/20250513-chained-and-efficient-upgrades-for-clusters-with-managed-topologies.md

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -247,8 +247,11 @@ consistent with `controlPlaneUpgrades` and also compliant with the [Kubernetes v
247247
- version: v1.31.0
248248
- version: v1.32.3
249249
```
250-
251-
Please note:
250+
251+
Note: in this case the system will take into consideration the provided `workersUpgrades`, and validated it is
252+
consistent with `controlPlaneUpgrades` and also compliant with the [Kubernetes version skew policy](https://kubernetes.io/releases/version-skew-policy/).
253+
254+
Plase also consider that:
252255
- In case both the list of Kubernetes versions and the runtime extension definition will be left empty in a cluster class,
253256
Cluster API will behave as of today: only upgrades to the next minor are allowed for the corresponding clusters.
254257
- If the list of Kubernetes versions is defined in a ClusterClass, the system is going to use this info also in

0 commit comments

Comments
 (0)