Skip to content

Commit 7111e4f

Browse files
committed
Add hint to look into controller logs to runtime client error response
Signed-off-by: Stefan Büringer [email protected]
1 parent 15a4355 commit 7111e4f

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

internal/runtime/client/client.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ func (c *client) Discover(ctx context.Context, extensionConfig *runtimev1.Extens
124124
if response.GetStatus() == runtimehooksv1.ResponseStatusFailure {
125125
log.Info(fmt.Sprintf("Failed to discover extension %q: got failure response with message %v", extensionConfig.Name, response.GetMessage()))
126126
// Don't add the message to the error as it is may be unique causing too many reconciliations. Ref: https://github.com/kubernetes-sigs/cluster-api/issues/6921
127-
return nil, errors.Errorf("failed to discover extension %q: got failure response", extensionConfig.Name)
127+
return nil, errors.Errorf("failed to discover extension %q: got failure response, please check controller logs for errors", extensionConfig.Name)
128128
}
129129

130130
// Check to see if the response is valid.
@@ -366,7 +366,7 @@ func (c *client) CallExtension(ctx context.Context, hook runtimecatalog.Hook, fo
366366
if response.GetStatus() == runtimehooksv1.ResponseStatusFailure {
367367
log.Info(fmt.Sprintf("Failed to call extension handler %q: got failure response with message %v", name, response.GetMessage()))
368368
// Don't add the message to the error as it is may be unique causing too many reconciliations. Ref: https://github.com/kubernetes-sigs/cluster-api/issues/6921
369-
return errors.Errorf("failed to call extension handler %q: got failure response", name)
369+
return errors.Errorf("failed to call extension handler %q: got failure response, please check controller logs for errors", name)
370370
}
371371

372372
if retryResponse, ok := response.(runtimehooksv1.RetryResponseObject); ok && retryResponse.GetRetryAfterSeconds() != 0 {

0 commit comments

Comments
 (0)