Skip to content

Commit 7bd466a

Browse files
authored
Merge pull request #12791 from sbueringer/pr-webhook-rename
🌱 Consistent webhook file/folder structure
2 parents 918b7d8 + d1aeba9 commit 7bd466a

23 files changed

+45
-71
lines changed

config/webhook/manifests.yaml

Lines changed: 42 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -55,20 +55,20 @@ webhooks:
5555
service:
5656
name: webhook-service
5757
namespace: system
58-
path: /mutate-cluster-x-k8s-io-v1beta2-machine
58+
path: /mutate-runtime-cluster-x-k8s-io-v1beta2-extensionconfig
5959
failurePolicy: Fail
6060
matchPolicy: Equivalent
61-
name: default.machine.cluster.x-k8s.io
61+
name: default.extensionconfig.runtime.addons.cluster.x-k8s.io
6262
rules:
6363
- apiGroups:
64-
- cluster.x-k8s.io
64+
- runtime.cluster.x-k8s.io
6565
apiVersions:
6666
- v1beta2
6767
operations:
6868
- CREATE
6969
- UPDATE
7070
resources:
71-
- machines
71+
- extensionconfigs
7272
sideEffects: None
7373
- admissionReviewVersions:
7474
- v1
@@ -77,10 +77,10 @@ webhooks:
7777
service:
7878
name: webhook-service
7979
namespace: system
80-
path: /mutate-cluster-x-k8s-io-v1beta2-machinedeployment
80+
path: /mutate-cluster-x-k8s-io-v1beta2-machine
8181
failurePolicy: Fail
8282
matchPolicy: Equivalent
83-
name: default.machinedeployment.cluster.x-k8s.io
83+
name: default.machine.cluster.x-k8s.io
8484
rules:
8585
- apiGroups:
8686
- cluster.x-k8s.io
@@ -90,7 +90,7 @@ webhooks:
9090
- CREATE
9191
- UPDATE
9292
resources:
93-
- machinedeployments
93+
- machines
9494
sideEffects: None
9595
- admissionReviewVersions:
9696
- v1
@@ -99,10 +99,10 @@ webhooks:
9999
service:
100100
name: webhook-service
101101
namespace: system
102-
path: /mutate-cluster-x-k8s-io-v1beta2-machinehealthcheck
102+
path: /mutate-cluster-x-k8s-io-v1beta2-machinedeployment
103103
failurePolicy: Fail
104104
matchPolicy: Equivalent
105-
name: default.machinehealthcheck.cluster.x-k8s.io
105+
name: default.machinedeployment.cluster.x-k8s.io
106106
rules:
107107
- apiGroups:
108108
- cluster.x-k8s.io
@@ -112,7 +112,7 @@ webhooks:
112112
- CREATE
113113
- UPDATE
114114
resources:
115-
- machinehealthchecks
115+
- machinedeployments
116116
sideEffects: None
117117
- admissionReviewVersions:
118118
- v1
@@ -121,10 +121,10 @@ webhooks:
121121
service:
122122
name: webhook-service
123123
namespace: system
124-
path: /mutate-cluster-x-k8s-io-v1beta2-machinepool
124+
path: /mutate-cluster-x-k8s-io-v1beta2-machinehealthcheck
125125
failurePolicy: Fail
126126
matchPolicy: Equivalent
127-
name: default.machinepool.cluster.x-k8s.io
127+
name: default.machinehealthcheck.cluster.x-k8s.io
128128
rules:
129129
- apiGroups:
130130
- cluster.x-k8s.io
@@ -134,7 +134,7 @@ webhooks:
134134
- CREATE
135135
- UPDATE
136136
resources:
137-
- machinepools
137+
- machinehealthchecks
138138
sideEffects: None
139139
- admissionReviewVersions:
140140
- v1
@@ -143,10 +143,10 @@ webhooks:
143143
service:
144144
name: webhook-service
145145
namespace: system
146-
path: /mutate-cluster-x-k8s-io-v1beta2-machineset
146+
path: /mutate-cluster-x-k8s-io-v1beta2-machinepool
147147
failurePolicy: Fail
148148
matchPolicy: Equivalent
149-
name: default.machineset.cluster.x-k8s.io
149+
name: default.machinepool.cluster.x-k8s.io
150150
rules:
151151
- apiGroups:
152152
- cluster.x-k8s.io
@@ -156,7 +156,7 @@ webhooks:
156156
- CREATE
157157
- UPDATE
158158
resources:
159-
- machinesets
159+
- machinepools
160160
sideEffects: None
161161
- admissionReviewVersions:
162162
- v1
@@ -165,20 +165,20 @@ webhooks:
165165
service:
166166
name: webhook-service
167167
namespace: system
168-
path: /mutate-runtime-cluster-x-k8s-io-v1beta2-extensionconfig
168+
path: /mutate-cluster-x-k8s-io-v1beta2-machineset
169169
failurePolicy: Fail
170170
matchPolicy: Equivalent
171-
name: default.extensionconfig.runtime.addons.cluster.x-k8s.io
171+
name: default.machineset.cluster.x-k8s.io
172172
rules:
173173
- apiGroups:
174-
- runtime.cluster.x-k8s.io
174+
- cluster.x-k8s.io
175175
apiVersions:
176176
- v1beta2
177177
operations:
178178
- CREATE
179179
- UPDATE
180180
resources:
181-
- extensionconfigs
181+
- machinesets
182182
sideEffects: None
183183
---
184184
apiVersion: admissionregistration.k8s.io/v1
@@ -276,6 +276,28 @@ webhooks:
276276
resources:
277277
- clusterresourcesetbindings
278278
sideEffects: None
279+
- admissionReviewVersions:
280+
- v1
281+
- v1beta1
282+
clientConfig:
283+
service:
284+
name: webhook-service
285+
namespace: system
286+
path: /validate-runtime-cluster-x-k8s-io-v1beta2-extensionconfig
287+
failurePolicy: Fail
288+
matchPolicy: Equivalent
289+
name: validation.extensionconfig.runtime.cluster.x-k8s.io
290+
rules:
291+
- apiGroups:
292+
- runtime.cluster.x-k8s.io
293+
apiVersions:
294+
- v1beta2
295+
operations:
296+
- CREATE
297+
- UPDATE
298+
resources:
299+
- extensionconfigs
300+
sideEffects: None
279301
- admissionReviewVersions:
280302
- v1
281303
- v1beta1
@@ -454,25 +476,3 @@ webhooks:
454476
resources:
455477
- machinesets
456478
sideEffects: None
457-
- admissionReviewVersions:
458-
- v1
459-
- v1beta1
460-
clientConfig:
461-
service:
462-
name: webhook-service
463-
namespace: system
464-
path: /validate-runtime-cluster-x-k8s-io-v1beta2-extensionconfig
465-
failurePolicy: Fail
466-
matchPolicy: Equivalent
467-
name: validation.extensionconfig.runtime.cluster.x-k8s.io
468-
rules:
469-
- apiGroups:
470-
- runtime.cluster.x-k8s.io
471-
apiVersions:
472-
- v1beta2
473-
operations:
474-
- CREATE
475-
- UPDATE
476-
resources:
477-
- extensionconfigs
478-
sideEffects: None
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.

internal/webhooks/runtime/extensionconfig_webhook.go renamed to internal/webhooks/extensionconfig.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ See the License for the specific language governing permissions and
1414
limitations under the License.
1515
*/
1616

17-
package runtime
17+
package webhooks
1818

1919
import (
2020
"context"

internal/webhooks/runtime/extensionconfig_webhook_test.go renamed to internal/webhooks/extensionconfig_test.go

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -14,29 +14,22 @@ See the License for the specific language governing permissions and
1414
limitations under the License.
1515
*/
1616

17-
package runtime
17+
package webhooks
1818

1919
import (
2020
"context"
2121
"testing"
2222

2323
. "github.com/onsi/gomega"
2424
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
25-
"k8s.io/apimachinery/pkg/runtime"
2625
utilfeature "k8s.io/component-base/featuregate/testing"
2726
"k8s.io/utils/ptr"
28-
ctrl "sigs.k8s.io/controller-runtime"
2927

3028
runtimev1 "sigs.k8s.io/cluster-api/api/runtime/v1beta2"
3129
"sigs.k8s.io/cluster-api/feature"
3230
"sigs.k8s.io/cluster-api/internal/webhooks/util"
3331
)
3432

35-
var (
36-
ctx = ctrl.SetupSignalHandler()
37-
fakeScheme = runtime.NewScheme()
38-
)
39-
4033
func init() {
4134
_ = runtimev1.AddToScheme(fakeScheme)
4235
}

internal/webhooks/runtime/doc.go

Lines changed: 0 additions & 18 deletions
This file was deleted.

0 commit comments

Comments
 (0)